Add ENUMERATION_SOURCE
#406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vaitkus
reviewed
Jun 2, 2023
Co-authored-by: Antanas Vaitkus <antanas.vaitkus90@gmail.com>
vaitkus
reviewed
Jun 2, 2023
Co-authored-by: Antanas Vaitkus <antanas.vaitkus90@gmail.com>
Co-authored-by: Antanas Vaitkus <antanas.vaitkus90@gmail.com>
Co-authored-by: Antanas Vaitkus <antanas.vaitkus90@gmail.com>
Co-authored-by: Antanas Vaitkus <antanas.vaitkus90@gmail.com>
so you don't need to have an id if you're just giving one reference
vaitkus
reviewed
Jun 3, 2023
Merged
jamesrhester
reviewed
Jun 5, 2023
| a specific enumeration value. | ||
| ; | ||
| _name.category_id enumeration_default | ||
| _name.object_id source_id |
There was a problem hiding this comment.
Aren't we now using ENUMERATION_DEFAULTS? (S on the end)
There was a problem hiding this comment.
That's in #404, and not merged yet.
|
Looks fine, just needs to be rewritten in terms of |
Roger that. Just need |
|
@jamesrhester @rowlesmr Maybe we could merge this PR as is and then simply update it once the After all, the |
|
Agreed and merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will close #402
Add ability to record the source of the values in a default enumeration (ie the ones in
templ_enum.cif) to be recorded.