Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rnaturalearth install error #61

Merged
merged 6 commits into from
Mar 1, 2022
Merged

Fix rnaturalearth install error #61

merged 6 commits into from
Mar 1, 2022

Conversation

bpbond
Copy link
Member

@bpbond bpbond commented Feb 23, 2022

@bpbond
Copy link
Member Author

bpbond commented Feb 24, 2022

@kendalynnm I have fixed the yaml problem, but the RMarkdown is still erroring because of something else — I looked, and the new TEMPEST prediction code is the problem. This occurs on my local system as well. Over to you to fix :)

@bpbond bpbond changed the title Try to fix rnaturalearth install error Fix rnaturalearth install error Feb 24, 2022
@kendalynnm
Copy link
Collaborator

kendalynnm commented Feb 28, 2022

Got it, this is because the big GeoTiff files don't exist within the GitHub repo (assuming I'm using that lingo correctly). Maybe we should make it so that the soil grids data is all 1's if the tiffs aren't present? With a big neon warning sign? That would fix the render problem.

@bpbond
Copy link
Member Author

bpbond commented Feb 28, 2022

Maybe we should make it so that the soil grids data is all 1's if the tiffs aren't present? With a big neon warning sign?

That's what we do already:

  # geoTIFF files are not present
  # issue a warning
  warning("geoTIFF files are not present! Analysis will not be correct")
  meta_df$sg_clay <- 1
  meta_df$sg_ocs <- 1

Copy link
Collaborator

@kendalynnm kendalynnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good to me, thanks!

@bpbond
Copy link
Member Author

bpbond commented Feb 28, 2022

Hurray! OK, merge when ready, and then you can update #64 and make sure that test runs (it should).

@kendalynnm kendalynnm merged commit fbf5c26 into main Mar 1, 2022
@bpbond bpbond deleted the bpbond-patch-1 branch March 10, 2022 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants