Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completed all tasks #1

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

EshaanAgg
Copy link

@EshaanAgg EshaanAgg commented Jun 26, 2022

Repo
Deployment

Tasks

  • Auth Middleware
  • Login Function
  • Add task
  • Get tasks
  • Update Task
  • Delete Task
  • UI Improvement

Additional

  • Filtering of the tasks based on input (Case insensitive Regex filter)
  • Sorting of tasks in alphabetical and reverse alphabetical order
  • Validation while editing tasks (Disregard null tasks and check if the new value is different from old or not)

Copy link
Collaborator

@tiger-yash tiger-yash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A neat and clean implementation with nice additions to the UI.
Great use of toast alerts at every step.

Adding the Search feature was wise, but implementation and working can to be improved:

  • On searching empty text, all tasks should be visible (or clear filter button)
  • On deletion of a task after filtering, the DOM is not getting updated.
  • Feature Improvement : could have also looked into returning the results in real-time. ( Current Implementation is also great! )

pages/login/index.vue Outdated Show resolved Hide resolved
})
.then(() => {
this.$toast.success('Todo deleted successfully!')
this.todos.splice(_index, 1)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good use of splice

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Filtered Todos not updated

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just realized this. Any idea why is this happening?
I am updating this.todos as using the splice method, and the filteredTodos is itself a computed property defined on this.todos, so shouldn't it be updating automatically?

components/sortBar.vue Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants