Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API/TST/DOC Converge on final structure for BranchCollector #263

Closed
3 of 6 tasks
drewejohnson opened this issue Jan 21, 2019 · 2 comments
Closed
3 of 6 tasks

API/TST/DOC Converge on final structure for BranchCollector #263

drewejohnson opened this issue Jan 21, 2019 · 2 comments
Labels
API - Compatible Changes to our API that require no user actions API - Incompatible Incompatible changes to our API that require user actions documentation testing Related to our test suite
Projects
Main
Milestone
0.7.0

Comments

@drewejohnson
Copy link
Collaborator

drewejohnson commented Jan 21, 2019 •
edited

Reminder that we do want to finalize the experimental changes from #262. These include

  • Final / ideal data storage for multidimensional group constants
  • Testing of the above layout
  • Convert jupyter notebook to rst for documentation

Marked as API - Incompatible and API - Compatible because, depending on the changes, it could fall in to either of these categories

Smaller scope items

  • Store all group constants, not just 'inf' from coefficient file
  • Way to infer and/or not pass initial perturbations to collector
  • Add this as a "reader" type, so that this can be used directly from serpentTools.read
@drewejohnson drewejohnson added documentation API - Compatible Changes to our API that require no user actions API - Incompatible Incompatible changes to our API that require user actions testing Related to our test suite labels Jan 21, 2019
@drewejohnson drewejohnson added this to the 0.7.0 milestone Jan 21, 2019
@drewejohnson drewejohnson added this to To do in Main Jan 22, 2019
@drewejohnson
Copy link
Collaborator Author

#262 resolved some testing, documentation, and option to store all group constants

@drewejohnson
Copy link
Collaborator Author

#276 resolved some issues, namely

  1. Don't require passing the perturbations to the collector
  2. Create a collector with a .read style format using BranchCollector.fromFile class method

@drewejohnson drewejohnson moved this from To do to In progress in Main Mar 14, 2019
drewejohnson pushed a commit to drewejohnson/serpent-tools that referenced this issue Mar 14, 2019
DEV Remove experimental notices on BranchCollector
a93c5fa 
Closes CORE-GATECH-GROUP#263 as the BranchCollector API is stable for first
API release.
@drewejohnson drewejohnson mentioned this issue Mar 14, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
API - Compatible Changes to our API that require no user actions API - Incompatible Incompatible changes to our API that require user actions documentation testing Related to our test suite
Projects
Main
In progress
Milestone
0.7.0
Development

No branches or pull requests
1 participant
@drewejohnson