DEV/REL/BUG Merge 0.9.1 into develop #369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related to GH issue CORE-GATECH-GROUP#365, where the use of the new Serpent sens opt history 1 option prints out additional sensitivity data. In this mode, sensitivities using 1<=n<N latent generations are printed, where N is the number specified using sens opt latgen argument. This creates new arrays of the form ADJ_PERT_SENS_<RESP>_<N>_GEN ADJ_PERT_SENS_<RESP>_<N>_GEN_E_INT to the sensitivity files. As reported in the issue, serpentTools would store the last set of <N>_GEN as the actual response, so the value stored would reflect data using one fewer latent generations. The sensitivity test file is modified to include four new arrays, ADJ_PERT_keff_SENS_1_GEN ADJ_PERT_keff_SENS_1_GEN_E_INT ADJ_PERT_fis2flx_SENS_1_GEN ADJ_PERT_fis2flx_SENS_1_GEN_E_INT These arrays are identical the non _1_GEN values, except the very first value and associated uncertainty are set to zero. Running the sensitivity file test will fail due to this change, as the reference data have not been changed in the file, but are overwritten as reported in the issue.
This closes GH issue CORE-GATECH-GROUP#356 but changing how arrays are processed in the sensitivity reader. The variable names are processed using a single for-loop rather than multiple index calls. The new routine also reads the _N_GEN information to be used later in storing these arrays. Examination of these arrays can help the determination of ideal number of latent generations, as described in the Serpent Wiki using the sens opt history setting.
Don't overwrite sensitivity data with _N_GEN variables
Point to GitHub issue CORE-GATECH-GROUP#367 to indicate we are aware of the desire to store arrays over variable number of latent generations, but do not store them currently.
Bump version to 0.9.1 in setup.py, serpentTools/__init__.py, and docs/conf.py. Updated changelog to reflect handling of sensitivity history arrays
REL Release version 0.9.1
Preserve development version 0.10.0.dev0 in docs/conf.py, setup.py, and serpentTools/__init__.py
drewejohnson
added
bug
release
DanKotlyar
approved these changes
Dec 16, 2019
drewejohnson
added a commit
to drewejohnson/serpent-tools
that referenced
this pull request
May 23, 2020
Backport of features included since 0.9.3 release Includes the following PRs git log --online --pretty="%s" --merges 0.9.3... Merge pull request CORE-GATECH-GROUP#407 from drewejohnson/fix-readme Merge pull request CORE-GATECH-GROUP#406 from drewejohnson/r0.9.3 Merge pull request CORE-GATECH-GROUP#405 from nicoloabrate/master Merge pull request CORE-GATECH-GROUP#404 from drewejohnson/update-git-attr Merge pull request CORE-GATECH-GROUP#402 from drewejohnson/xsplot-labels Merge pull request CORE-GATECH-GROUP#400 from drewejohnson/lib2-notes Merge pull request CORE-GATECH-GROUP#399 from CORE-GATECH-GROUP/docs-sphinx-2.0 Merge pull request CORE-GATECH-GROUP#397 from drewejohnson/port-list-of-arrays Merge pull request CORE-GATECH-GROUP#398 from drewejohnson/det-supers Merge pull request CORE-GATECH-GROUP#396 from drewejohnson/df-arg-renaming Merge pull request CORE-GATECH-GROUP#394 from drewejohnson/0.9.3-update-docs Merge pull request CORE-GATECH-GROUP#395 from drewejohnson/hist-branch-dictlike Merge pull request CORE-GATECH-GROUP#393 from drewejohnson/less-metadata Merge pull request CORE-GATECH-GROUP#392 from drewejohnson/better-access Merge pull request CORE-GATECH-GROUP#391 from drewejohnson/dep-dataframe Merge pull request CORE-GATECH-GROUP#390 from drewejohnson/api-dep-attributes Merge pull request CORE-GATECH-GROUP#388 from drewejohnson/xsplot-branch Merge pull request CORE-GATECH-GROUP#378 from drewejohnson/better-build Merge pull request CORE-GATECH-GROUP#376 from drewejohnson/unbundle-data-files Merge pull request CORE-GATECH-GROUP#370 from drewejohnson/results-loa Merge pull request CORE-GATECH-GROUP#369 from drewejohnson/merge-0.9.1-develop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce the bug fix and release data from #366, #368 into the develop branch. Develop version
0.10.0.dev0is preserved