Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better names for Examples #418

Merged
merged 5 commits into from
Jul 10, 2024
Merged

Better names for Examples #418

merged 5 commits into from
Jul 10, 2024

Conversation

navidcy
Copy link
Collaborator

@navidcy navidcy commented Jul 9, 2024

Closes #412

@navidcy navidcy marked this pull request as draft July 9, 2024 12:44
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@navidcy navidcy marked this pull request as ready for review July 9, 2024 12:55
@navidcy navidcy requested review from adele-morrison and a team July 9, 2024 12:55
@navidcy
Copy link
Collaborator Author

navidcy commented Jul 9, 2024

I didn't run the examples. I just renamed them.

@navidcy navidcy requested a review from angus-g July 10, 2024 05:37
Copy link
Collaborator

@adele-morrison adele-morrison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay, new names!

@navidcy navidcy merged commit 697e230 into main Jul 10, 2024
3 checks passed
@navidcy navidcy deleted the ncc-akm/rename-examples branch July 10, 2024 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Renaming Example notebooks
2 participants