Update variables api #29
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hidde-jan
commented
Mar 8, 2024
| Value string `bson:"value,omitempty" json:"value,omitempty"` | ||
| Constant bool `bson:"constant,omitempty" json:"constant,omitempty"` | ||
| External bool `bson:"external,omitempty" json:"external,omitempty"` | ||
| // Initialize new Variables |
There was a problem hiding this comment.
@MaartendeKruijf is this closer to the interface you'd like to see? It's inspired by the CPP map interface.
There was a problem hiding this comment.
Looks good updated it with parsing json and pass by pointer
MaartendeKruijf
force-pushed
the
update-variables-api
branch
from
48224ff
to
1cdeb1b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement a new API for Variable usage in playbooks and steps