Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes compilation issue with clang #339

Merged

Conversation

sebastienraillet
Copy link
Contributor

Hello all,

Trying to compile the latest version available (2.18.8) with clang doesn't work anymore (see #338).

This PR is about fixing this issue :

  • function atomic_compare_exchange_strong() expect a pointer to an _Atomic type. dlt_user_initialised is now an atomic_bool
  • function dlt_set_filesize_max() returned a DLT_LOG_ERROR which isn't a DltReturnValue. This commit replaces DLT_LOG_ERROR by DLT_RETURN_ERROR which is the expected return type

* function atomic_compare_exchange_strong expect a pointer to an _Atomic type. dlt_user_initialised is now an atomic_bool
* function dlt_set_filesize_max returned a DLT_LOG_ERROR which isn't a DltReturnValue. This commit replaces DLT_LOG_ERROR by DLT_RETURN_ERROR which is the expected return type

Signed-off-by: Sebastien RAILLET <sebastien.raillet@marelli.com>
@ssugiura ssugiura merged commit cc7ed02 into COVESA:master Oct 13, 2021
@sebastienraillet sebastienraillet deleted the fix_clang_compilation_issue branch November 8, 2021 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants