cmake: disable network trace #477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexmohr
force-pushed
the
disable-network-trace
branch
from
ee116a2
to
a0594c5
Compare
|
Hello @michael-methner |
src/lib/dlt_user.c
Outdated
| (void)header; | ||
| (void)payload_len; | ||
| (void)payload; | ||
| return DLT_RETURN_OK; |
There was a problem hiding this comment.
I would prefer returning an error code here. vsomeip is anyhow not checking it and logging a warning.
There was a problem hiding this comment.
Changed return code DLT_RETURN_LOGGING_DISABLED and added dummy implementation for dlt_user_trace_network_truncated as this is also used in newer version of vsomeip
There was a problem hiding this comment.
Perfect, thanks for the rework
Add cmake toggle to disable network trace. Disable network trace for QNX and yocto. Deactivate DLT_TRACE_NETWORK_SEGMENTED macro via an empty dlt_user_trace_network_segmented function to support someip build. Signed-off-by: Alexander Mohr <alexander.m.mohr@mercedes-benz.com>
alexmohr
force-pushed
the
disable-network-trace
branch
from
a0594c5
to
5be6739
Compare
michael-methner
approved these changes
Aug 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add cmake toggle to disable network trace.
Disable network trace for QNX and yocto.
Deactivate DLT_TRACE_NETWORK_SEGMENTED macro
via an empty dlt_user_trace_network_segmented
function to support someip build.
The program was tested solely for our own use cases, which might differ from yours.
Licensed under Mozilla Public License Version 2.0
Alexander Mohr, alexander.m.mohr@mercedes-benz.com, Mercedes-Benz Tech Innovation GmbH, imprint