Introducing Battery Connection signals #350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Meeting notes: Clarify that the reason for plural is that there are two connectors (on plus and minus) |
erikbosch
force-pushed
the
erik_battery
branch
from
09ce821
to
1e373ff
Compare
SebastianSchildt
approved these changes
Nov 2, 2021
|
Meeting 02/11/2021:
|
High Voltage Traction batteries can typically be disconnected from the rest of the vehicle. Multiple connectors may exist and may be handled independently. For example, during charging ground/minus might be connected but not power/plus.
erikbosch
force-pushed
the
erik_battery
branch
from
1e373ff
to
9230ecf
Compare
erikbosch
changed the title
erikbosch
commented
Nov 9, 2021
| # | ||
|
|
||
| # It might be possible to disconnect the traction battery used by an electric powertrain. | ||
| # This is achieved by connectors, typically one for plus and one for minus. | ||
| PowerConnected: |
There was a problem hiding this comment.
We got some additional information internally on that connectors for power/plus and ground/minus are handled separately in at least some vehicles, to handle different use cases. A typical example is:
- Vehicle off, no charging: Both connectors disconnected/open
- Vehicle off, charging: Ground connector connected/closed, Power connector disconnected/open
- Vehicle on: Both connectors connected/closed
Based on this we propose to introducing two separate boolean sensor signals.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed as part of #338