Refactoring charge plug signals and clarifying enum naming recommendations #388
Conversation
erikbosch
force-pushed
the
erik_chargeport
branch
2 times, most recently
from
34489ca
to
14e0e9a
Compare
erikbosch
changed the title
docs-gen/content/rule_set/basics.md
Outdated
| default: UNKNOWN | ||
| enum: [UNKNOWN, ALT_1, ALT_2] | ||
| ``` | ||
|
|
There was a problem hiding this comment.
In general I think this applies to the 'allowedValues' change as well. Just still not sure if we should recommend the use 'UNKNOWN'.
I'd prefer a recommendation for the implementation.
There was a problem hiding this comment.
I agree that it would be good if VSS at least states a recommended approach for allowed, especially concerning undefined/unknown. I can see two major tracks:
- Recommend that first
allowedvalue for strings always shall beUNKNOWN. Or e.g.UNDEFINEDif we consider that a better choice. At least for actuatorsUNDEFINEDmight be a better option as it could be used to state that you do not care, for instance if someone would like to use something like VSS to specify rental car preferences. - Recommend that
UNKNOWN(or similar) generally not shall be used, unless there are good reasons, e.g. compatibility with values from an existing standard/protocol
|
@erikbosch, it would be great, if we could separate the documentation proposal from the actual changes. My proposal: let's get #381 merged, create a PR for the docs on top of that one and then do the actual changes. What do you think? |
|
@danielwilms - your suggestion makes sense. I will convert this one to a draft and adapt it when #381 and related changes are merged |
Fixes COVESA#376 Merging the two existing signals to a common signal Inspired by EvConnectorType in https://android.googlesource.com/platform/hardware/interfaces/+/master/automotive/vehicle/2.0/types.hal See https://www.evexpert.eu/eshop1/knowledge-center/connector-types-for-ev-charging-around-the-world for general information on connector types
erikbosch
force-pushed
the
erik_chargeport
branch
from
14e0e9a
to
ff607fd
Compare
|
Closing this one, will replace the charge plug signal renaming with a different PR |
Fixes #376
Merging the two existing signals to a common signal. Aligned with EvConnectorType in https://android.googlesource.com/platform/hardware/interfaces/+/master/automotive/vehicle/2.0/types.hal - it seems to be quite exhaustive and also include some Tesla-specific connectors.
As of today we are are a bit inconsistent on enum symbols (string literals) in VSS concerning style. Here using a pattern with underscore and upper case letters, but I am open to using a different pattern. As long as we do not use whitespace I am happy. As the signals involved in this change also are used as examples I took the liberty to also extend and change the documentation accordingly.
See https://www.evexpert.eu/eshop1/knowledge-center/connector-types-for-ev-charging-around-the-world
for general information on connector types