Adding name recommendations for allowed values #399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikbosch
force-pushed
the
erik_allowed
branch
from
2fff34c
to
827022f
Compare
erikbosch
force-pushed
the
erik_allowed
branch
from
827022f
to
ee46dbc
Compare
SebastianSchildt
approved these changes
Jan 17, 2022
Comment on lines
+31
to
+32
| For string values used for `default` and `allowed` statements it is recommended to start with `A-Z` | ||
| and then use only `A-Z`, `0-9` and underscore (`_`). |
There was a problem hiding this comment.
Could it start with underscore too? this would follow most variable naming conventions for constants.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up to #388, based on the proposal that allowed values preferably shall be upper case with parts separated by underscore.
I also renamed the file name form
enum.mdtoallowed.md