Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUILD] Changed buildcheck.yaml to pyenv and Pipfile #397

Merged
merged 1 commit into from
Jan 18, 2022

Conversation

danielwilms
Copy link
Collaborator

We changed in vss-tools from requirements.txt to
Pipfile and in order to update the submodule
we have to do the change here in VSS as well.

Updated buildcheck.yaml:

  • changed to pyenv instead of python action
  • Use Pipfile instead of requirements.txt

Related to: COVESA/vss-tools#131

Signed-off-by: Daniel Wilms Daniel.DW.Wilms@bmw.de

We changed in vss-tools from `requirements.txt` to
`Pipfile` and in order to update the submodule
we have to do the change here in VSS as well.

Updated `buildcheck.yaml`:
* changed to pyenv instead of python action
* Use `Pipfile` instead of `requirements.txt`

Related to: COVESA/vss-tools#131

Signed-off-by: Daniel Wilms <Daniel.DW.Wilms@bmw.de>
@erikbosch
Copy link
Collaborator

The run give some complains on Pyton versions. I assume at least one explanation is that we still use the old vss-tools submodule, or?

https://github.com/COVESA/vehicle_signal_specification/runs/4788041057?check_suite_focus=true
Warning: Your Pipfile requires python_version 3.8.5, but you are using 3.8.10 (/home/runner/work/v/v/v/.venv/bin/python).

@danielwilms
Copy link
Collaborator Author

danielwilms commented Jan 13, 2022

is that we still use the old vss-tools submodule, or?

Indeed. I didn't wanna do another update then. When updating the submodule it should use the correct 3.8.12 installed by pyenv. I think we can update the submodule when we have the allowed support, then we clutter the commit history a bit less.

@danielwilms
Copy link
Collaborator Author

agreed to merge 2022/01/18

@danielwilms danielwilms merged commit cc44067 into COVESA:master Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants