[BUILD] Move from requirements.txt to Pipfile
#131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barbieri
reviewed
Jan 6, 2022
barbieri
approved these changes
Jan 6, 2022
Until now dependencies were defined in two separate files (requirements.txt and Pipfile). As decided in COVESA#114 we'll move to `Pipfile`. * removed `requirements.txt` to avoid confusion * removed section from `README.md` * changed `buildcheck.yml` to use `pipenv` Fixes: COVESA#114 Signed-off-by: Daniel Wilms <Daniel.DW.Wilms@bmw.de>
danielwilms
force-pushed
the
action2pipenv
branch
from
ff3f156
to
d9db3d6
Compare
|
@barbieri, I changed the python version in a separate commit, but in the same PR. Please have a look, if now everything is resolved. |
erikbosch
reviewed
Jan 10, 2022
Moved to the latest security release, as porposed by @barbieri. * Updated Pipfile, and resulting changes in Pipfile.lock * Updated buildscript * Updated README.md Signed-off-by: Daniel Wilms <Daniel.DW.Wilms@bmw.de>
danielwilms
force-pushed
the
action2pipenv
branch
from
55f0dcd
to
275f931
Compare
barbieri
approved these changes
Jan 10, 2022
SebastianSchildt
approved these changes
Jan 10, 2022
|
meeting 11/01/2022: approved to be merged @erikbosch |
danielwilms
added a commit
to danielwilms/vehicle_signal_specification
that referenced
this pull request
Jan 12, 2022
We changed in vss-tools from `requirements.txt` to `Pipfile` and in order to update the submodule we have to do the change here in VSS as well. Updated `buildcheck.yaml`: * changed to pyenv instead of python action * Use `Pipfile` instead of `requirements.txt` Related to: COVESA/vss-tools#131 Signed-off-by: Daniel Wilms <Daniel.DW.Wilms@bmw.de>
danielwilms
added a commit
to danielwilms/vehicle_signal_specification
that referenced
this pull request
Jan 12, 2022
We changed in vss-tools from `requirements.txt` to `Pipfile` and in order to update the submodule we have to do the change here in VSS as well. Updated `buildcheck.yaml`: * changed to pyenv instead of python action * Use `Pipfile` instead of `requirements.txt` Related to: COVESA/vss-tools#131 Signed-off-by: Daniel Wilms <Daniel.DW.Wilms@bmw.de>
danielwilms
added a commit
to danielwilms/vehicle_signal_specification
that referenced
this pull request
Jan 12, 2022
We changed in vss-tools from `requirements.txt` to `Pipfile` and in order to update the submodule we have to do the change here in VSS as well. Updated `buildcheck.yaml`: * changed to pyenv instead of python action * Use `Pipfile` instead of `requirements.txt` Related to: COVESA/vss-tools#131 Signed-off-by: Daniel Wilms <Daniel.DW.Wilms@bmw.de>
danielwilms
added a commit
to COVESA/vehicle_signal_specification
that referenced
this pull request
Jan 18, 2022
We changed in vss-tools from `requirements.txt` to `Pipfile` and in order to update the submodule we have to do the change here in VSS as well. Updated `buildcheck.yaml`: * changed to pyenv instead of python action * Use `Pipfile` instead of `requirements.txt` Related to: COVESA/vss-tools#131 Signed-off-by: Daniel Wilms <Daniel.DW.Wilms@bmw.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until now dependencies were defined in two separate files
(requirements.txt and Pipfile). As decided in #114 we'll
move to
Pipfile.requirements.txtto avoid confusionREADME.mdbuildcheck.ymlto usepipenvFixes: #114
Signed-off-by: Daniel Wilms Daniel.DW.Wilms@bmw.de