Motorbike signals as additional layer #450
Conversation
| # Changed instantiation | ||
| Vehicle.Chassis.Axle.Wheel: | ||
| type: branch | ||
| instances: ["Center"] |
There was a problem hiding this comment.
Here we could actually consider removing instance as we have only one instance. Or we can at least discuss - do we want to keep instance in a layer if it only will contain one instance and the instance name does not exist in "base" VSS?
There was a problem hiding this comment.
I think at the end it's a matter of taste. Here background in the internal discussion was to keep the general structure in comparison to the vehicle. But definitely something to discuss
| instances: ["Center"] | ||
|
|
||
| # Branches used for the structure, not adopted in any way | ||
| Vehicle.Cabin: |
There was a problem hiding this comment.
Maybe we should discuss how useful it is to keep the "cabin" branch for motorbikes. I believe only a very small subset of the signals (like seat heating) would be reusable. The term "cabin" is not intuitive for most bikes, but relevant for some like https://en.wikipedia.org/wiki/BMW_C1
Maybe we need to have some guideline on when to modify a branch and when to replace it.
|
|
adopt to structure in #454 and merge. |
As discussed previously, mixing different kinds vehicles in one vspec structure might lead to too generic structures and confusion. One way to achieve such variety is through profiles as overlayes. This is a first proposal on how it could look like, open for discussion. Signed-off-by: Daniel Wilms <Daniel.DW.Wilms@bmw.de>
danielwilms
force-pushed
the
2022_05_31_motorbike
branch
from
7499651
to
7c22ae1
Compare
|
@erikbosch: could you do a quick sanity check please? I you give thumbs up, I'd merge |
|
Looks good @danielwilms |
As discussed previously (#447), mixing different kinds vehicles
in one vspec structure might lead to too generic structures
and confusion. One way to achieve such variety is through
layers. This is a first proposal on how it could look like,
open for discussion.
Signed-off-by: Daniel Wilms Daniel.DW.Wilms@bmw.de