Add pre-commit hook #571
Merged
Add pre-commit hook #571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And make it mandatory to pass and fix present errors To make sure that commits are signed off Signed-off-by: Erik Jaegervall <erik.jaegervall@se.bosch.com>
erikbosch
commented
Mar 29, 2023
| - id: check-yaml | ||
| - id: check-added-large-files | ||
|
|
||
| - repo: https://github.com/pycqa/flake8 |
There was a problem hiding this comment.
This is currently the same config as vss-tools. One could argue that we possibly could clean up as some parts like flake8 is not relevant as we do not have code here. Opinions are welcome
|
No comments received, to avoid conflicts merge this one now. I will keep an eye on any regressions in PR builds, if any |
jdacoello
pushed a commit
to jdacoello/vehicle_signal_specification
that referenced
this pull request
May 2, 2023
And make it mandatory to pass and fix present errors To make sure that commits are signed off Signed-off-by: Erik Jaegervall <erik.jaegervall@se.bosch.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And make it mandatory to pass and fix present errors
Signed-off-by: Erik Jaegervall erik.jaegervall@se.bosch.com