add removal of nodes / branches v2 #348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Niclas Wesemann <niclas.wesemann@motius.de>
|
hi @erikbosch @ppb2020 created this squashed and rebased PR, it includes all changes that we spoke about in PR #342 |
Signed-off-by: Niclas Wesemann <niclas.wesemann@motius.de>
|
MoM:
|
ppb2020
reviewed
Apr 9, 2024
| delete: true | ||
| ``` | ||
|
|
||
| Also, the delement element can be used on instances after they have been expanded. If you want to delete a node or |
There was a problem hiding this comment.
It's neat that this works, BTW. Cool!
As a side question, what kind of error is generated if one tries to delete a non-existing instance? Is it differentiated from an error message generated by trying to delete a node that has no instances?
There was a problem hiding this comment.
done even added a test for this case, it fails at this position in the code:
...
# Type presence should have been tested earlier, but is tested here again for completeness
if "type" not in self.source_dict.keys():
logging.error("Invalid VSS element %s, must have type", self.name)
sys.exit(-1)Signed-off-by: Niclas Wesemann <niclas.wesemann@motius.de>
Signed-off-by: Niclas Wesemann <niclas.wesemann@motius.de>
Signed-off-by: Niclas Wesemann <niclas.wesemann@motius.de>
|
Should be ready for merge now |
erikbosch
approved these changes
Apr 10, 2024
erikbosch
pushed a commit
that referenced
this pull request
May 3, 2024
* add 'delete' element for node/branch removal Signed-off-by: Niclas Wesemann <niclas.wesemann@motius.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a squashed and rebased version of PR #342, please follow the link for more details