-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Organize client folder & refactor NavBar & Fix i18 text #720
Organize client folder & refactor NavBar & Fix i18 text #720
Conversation
…oggle for More&Update the relative test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me at first glance, and this is definitely a much-needed adjustment. Nice work!
I'm not too sure what the refactor nav bar issue is, and if it's maybe a duplicate of the issue I made #716 at what appears to be at the same time? :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
While this all looks good and it should be ready to merge, I'd like to get one more codeowner approval on this before merging in (@acthelemann @pavel-ilin) Otherwise, i'll just merge it tomorrow though as we should really get this in |
56d9300
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies, wasn't thinking and dismissed stale reviews when I had to update after merging in other PRs. Needs a quick approval then should be good to go.
* update calendar month hover font * updated calendar tile color * update calendar with new hover color Co-authored-by: Carter Klein <carterklein13@gmail.com>
No worries at all @SomeMoosery |
…oggle for More&Update the relative test
…orona-tracker into organize-client-folder
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
All changes need to be discussed before proceeding. Failure to do so may result in the pull request being rejected.
Before submitting a pull request, please be sure to review:
Please include the issue number the pull request fixes by replacing YOUR-ISSUE-HERE in the text below.
Fixes #709 fixes #719 fixes #715
Summary
client
folderDetails
Test Plan (required)
Final Checklist
package.json
?1.0.9
=>1.0.10
yarn
notnpm
? (important!)yarn lint
on the code?