feat: add `@purplet/rest` to replace `@discordjs/rest` #33

paperdave · 2022-07-10T11:35:14Z

Closes #7 by implementing a rest client. Instead of explicitly relying on node.js or bun directly, we are using web standards and then @purplet/polyfill to add missing standards.

as it stands right now you need the polyfill for both runtimes: node <18 doesn't support fetch and formdata, and bun and node 18 have fetch but not formdata. this will probably get better in the future but idk how long that will be.

I also want to note this has modifications to @purplet/polyfill to get formdata working

Hycord · 2022-07-10T15:21:20Z

I'm bad at github, didn't mean to do that lmao

paperdave · 2022-07-10T16:20:04Z

lmao nice. oh we'll shouldn't make anything different happen

paperdave · 2022-07-10T22:31:20Z

last two commits implement files with form data. it's significant because the second commit changes the polyfill to mirror the web apis, so the implementation in rest is super simple.

* wrote 70-cli.md * ✨ Fix minor grammatical errors Co-authored-by: trubiso <trubiso@users.noreply.github.com> Co-authored-by: hycord <masen0914@gmail.com> Co-authored-by: trubiso <crishipohola@gmail.com> Co-authored-by: trubiso <trubiso@users.noreply.github.com>

paperdave · 2022-07-14T00:34:48Z

@purplet/rest is published on the next dist-tag. we could get some testing with it. last step here is replacing rest client in purplet itself.

paperdave · 2022-07-14T02:39:33Z

ready for code review.

Hycord

Needs to be tested before full 1.0.0 release
Otherwise, LGTM

paperdave added 2 commits July 10, 2022 07:01

basic rest client working

8b98be0

organise the code a bit, prepare for types

211570d

paperdave added enhancement New feature or request pkg:rest labels Jul 10, 2022

implement a simple but robust way of specifying routes

849f48d

Hycord marked this pull request as ready for review July 10, 2022 15:20

paperdave added 5 commits July 10, 2022 12:33

add user routes

f93df99

fix route types a bit. still don't have all the types

28e6031

add more routes

7e6131a

feat(rest): Implement multipart forms

e7cd6f0

fix(polyfill): formdata matches web spec exactly

c663155

Hycord and others added 12 commits July 10, 2022 22:39

Move all routes to individual files

0078ff7

Fix prettier format on save issue

c240919

Fix Imports, actually works now with file re-structure

4e7fb86

Update User.ts, makes it more readable.

8bb06c1

🔨 Fix User.ts, forgot to test. Will do that from now on

df36eb6

🔨 Fix User.ts, forgot to test. Will do that from now on

bc571ef

feat(rest): implement rate limiting besides 429

681044c

✨ Update eslint errors and remove console.log

2e9503c

✨ Fix global rate limit being set to 2/sec and not 50

dcce7bb

🔨 Add and routes

1340ad9

re-add Channel.ts because I'm dumb

c2b9bbd

CLI Docs (#39) (#40)

6c0f541

* wrote 70-cli.md * ✨ Fix minor grammatical errors Co-authored-by: trubiso <trubiso@users.noreply.github.com> Co-authored-by: hycord <masen0914@gmail.com> Co-authored-by: trubiso <crishipohola@gmail.com> Co-authored-by: trubiso <trubiso@users.noreply.github.com>

paperdave changed the title ~~Create @purplet/rest~~ feat: add @purplet/rest to replace @discordjs/rest Jul 11, 2022

Hycord and others added 3 commits July 11, 2022 17:44

🔨 Add routes.md to track the completion of endpoint support

05f300f

🔨 fill AuditLog.ts and Some Channel.ts

fa42d2a

support passing bun.file() as file data

3be2a99

paperdave and others added 20 commits July 11, 2022 22:48

feat: add DiscordAPIError class

7a9e2f6

✨ Update Channel.ts for testing

97fd250

fix(rest): post, patch, and put will have {} as the body

8f4e5ba

remove console.log

5cd90f9

✨ Update Channel.ts, supports channel-emoji endpoints now 🙃

5960d24

✨ test and update some endpoints

751335c

fix: emoji script

41f62e2

fix: rest responses were untyped

a517a2b

style: update readme

e018e7f

feat(rest): generate routes.ts based off discord-api-docs

11797a7

Clear routes.md to begin testing

cb257e9

feat(rest): simplify route types, smaller bundle

7697dc8

Merge branch 'rest' of github.com:CRBT-Team/Purplet into rest

755be5f

misc changes

6550eef

✨ Push some of the testing

b58d22b

ok

5809bc1

Merge branch 'rest' of github.com:CRBT-Team/Purplet into rest

7833390

chore(rest): setup publish

c6bf660

chore: add rest to root readme

59972b9

fix: build not preserving jsdoc + types

c65a822

paperdave added 2 commits July 13, 2022 22:34

chore(purplet): replace usage of rest in purplet

ebc4d73

chore(rest): add changeset

14227a5

Hycord approved these changes Jul 14, 2022

View reviewed changes

paperdave merged commit 0ac1bdd into main Jul 14, 2022

paperdave deleted the rest branch July 14, 2022 04:05

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add `@purplet/rest` to replace `@discordjs/rest` #33

feat: add `@purplet/rest` to replace `@discordjs/rest` #33

paperdave commented Jul 10, 2022 •

edited

Loading

Hycord commented Jul 10, 2022

paperdave commented Jul 10, 2022

paperdave commented Jul 10, 2022

paperdave commented Jul 14, 2022

paperdave commented Jul 14, 2022

Hycord left a comment

feat: add @purplet/rest to replace @discordjs/rest #33

feat: add @purplet/rest to replace @discordjs/rest #33

Conversation

paperdave commented Jul 10, 2022 • edited Loading

Hycord commented Jul 10, 2022

paperdave commented Jul 10, 2022

paperdave commented Jul 10, 2022

paperdave commented Jul 14, 2022

paperdave commented Jul 14, 2022

Hycord left a comment

Choose a reason for hiding this comment

feat: add `@purplet/rest` to replace `@discordjs/rest` #33

feat: add `@purplet/rest` to replace `@discordjs/rest` #33

paperdave commented Jul 10, 2022 •

edited

Loading