Roslaunch compatibility and module paths #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using a roslaunch file to load the action server roslaunch generates the `__name` and `__log` parameters automatically. These are now handled as arguments by the argParser.
…_cnn into roslaunch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
mesh_completion_servermodule didn't handle the arguments passed to it by roslaunch. I adapted the argparse setup slightly to solve it. Thensparameters is not optional and requires-nsas a flag.Furthermore
mesh_completion_serverwouldn't find the path to thereconstruction_networkmodule, this has been fixed.