Fix #264, builtin option can be safely used again with SWIG 4.0.2+ #342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TobiasWinchen
requested changes
Jun 9, 2021
|
OK, I'll remove these tests. I used them just to make sure nothing is changed physically in the process. macOS fails because it lacks the FFTW support - i.e., all turbulence features are disabled in CI. By removing tests this will not be an issue any more. |
|
The JF12 deprecation warning has nothing to do with the builtin, right? Would be cleaner to have this in a separate PR then. |
Yes, that's true - I accidentally mixed those two commits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is PR to fix #264, I've tested it with and without SWIG builtin enabled in cmake. Now, all tests pass regarding the vector3 representation, i.e., print(v), and the issue with keyword arguments. Also, the new test for checking out of range when setting or getting vector elements passes...