Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add my portfolio #109

Merged
merged 19 commits into from
Nov 11, 2018
Merged

Add my portfolio #109

merged 19 commits into from
Nov 11, 2018

Conversation

ChooJeremy
Copy link

No description provided.

@ChooJeremy ChooJeremy added the status.Ongoing The issue is currently being worked on. note: remove this label before closing an issue label Oct 23, 2018
@ChooJeremy ChooJeremy added this to the v1.4 milestone Oct 23, 2018
@ChooJeremy ChooJeremy self-assigned this Oct 23, 2018
@coveralls
Copy link

coveralls commented Oct 23, 2018

Pull Request Test Coverage Report for Build 842

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 124 unchanged lines in 24 files lost coverage.
  • Overall coverage increased (+2.0%) to 88.808%

Files with Coverage Reduction New Missed Lines %
src/main/java/seedu/address/storage/XmlAdaptedPerson.java 1 99.12%
src/main/java/seedu/address/model/person/Username.java 1 90.0%
src/main/java/seedu/address/logic/commands/AddAssignmentCommand.java 1 92.86%
src/main/java/seedu/address/logic/commands/AddCommand.java 1 95.0%
src/main/java/seedu/address/model/leaveapplication/LeaveApplication.java 1 96.88%
src/main/java/seedu/address/model/Model.java 1 80.0%
src/main/java/seedu/address/logic/commands/ClearCommand.java 1 88.89%
src/main/java/seedu/address/logic/commands/AutoCompleteCommandHelper.java 1 91.67%
src/main/java/seedu/address/logic/commands/SelectCommand.java 1 94.44%
src/main/java/seedu/address/model/person/Person.java 1 98.7%
Totals Coverage Status
Change from base Build 553: 2.0%
Covered Lines: 3309
Relevant Lines: 3726

💛 - Coveralls

@ChooJeremy ChooJeremy merged commit 90afaf9 into master Nov 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status.Ongoing The issue is currently being worked on. note: remove this label before closing an issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants