Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement archive feature #115

Merged
merged 13 commits into from
Oct 31, 2018

Conversation

jroberts91
Copy link

No description provided.

@jroberts91 jroberts91 added type.Story A user story status.Ongoing The issue is currently being worked on. note: remove this label before closing an issue priority.High Must do labels Oct 24, 2018
@jroberts91 jroberts91 added this to the v1.3 milestone Oct 24, 2018
@jroberts91 jroberts91 self-assigned this Oct 24, 2018
@coveralls
Copy link

Pull Request Test Coverage Report for Build 426

  • 105 of 187 (56.15%) changed or added relevant lines in 15 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-2.8%) to 90.533%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/main/java/seedu/address/MainApp.java 5 7 71.43%
src/main/java/seedu/address/model/UserPrefs.java 2 4 50.0%
src/main/java/seedu/address/storage/StorageManager.java 13 16 81.25%
src/main/java/seedu/address/storage/XmlFileStorage.java 4 8 50.0%
src/main/java/seedu/address/commons/events/ui/ListPickerSelectionChangedEvent.java 0 5 0.0%
src/main/java/seedu/address/storage/XmlArchiveListStorage.java 16 22 72.73%
src/main/java/seedu/address/storage/XmlSerializableArchiveList.java 13 19 68.42%
src/main/java/seedu/address/ui/ListPicker.java 6 14 42.86%
src/main/java/seedu/address/ui/MainWindow.java 4 12 33.33%
src/main/java/seedu/address/model/ArchiveList.java 15 24 62.5%
Totals Coverage Status
Change from base Build 395: -2.8%
Covered Lines: 2257
Relevant Lines: 2493

💛 - Coveralls

@jroberts91 jroberts91 merged commit e343346 into CS2103-AY1819S1-F10-1:master Oct 31, 2018
@jroberts91
Copy link
Author

see #114

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority.High Must do status.Ongoing The issue is currently being worked on. note: remove this label before closing an issue type.Story A user story
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants