Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implementation for add/delete features #83

Merged
merged 18 commits into from
Oct 17, 2018
Merged

Implementation for add/delete features #83

merged 18 commits into from
Oct 17, 2018

Conversation

jroberts91
Copy link

No description provided.

@jroberts91 jroberts91 self-assigned this Oct 16, 2018
@jroberts91 jroberts91 added this to the v1.2 milestone Oct 16, 2018
@jroberts91 jroberts91 added type.Epic A big feature which can be broken down into smaller stories e.g. search type.Story A user story status.Ongoing The issue is currently being worked on. note: remove this label before closing an issue priority.High Must do labels Oct 16, 2018
@coveralls
Copy link

coveralls commented Oct 17, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 148

  • 117 of 126 (92.86%) changed or added relevant lines in 12 files are covered.
  • 7 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.4%) to 91.649%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/main/java/seedu/address/model/person/Person.java 16 17 94.12%
src/main/java/seedu/address/model/person/Salary.java 9 10 90.0%
src/main/java/seedu/address/storage/XmlAdaptedProject.java 12 15 80.0%
src/main/java/seedu/address/storage/XmlAdaptedPerson.java 20 24 83.33%
Files with Coverage Reduction New Missed Lines %
src/main/java/seedu/address/storage/XmlAdaptedPerson.java 2 79.01%
src/main/java/seedu/address/ui/MainWindow.java 5 93.83%
Totals Coverage Status
Change from base Build 125: 0.4%
Covered Lines: 1712
Relevant Lines: 1868
💛 - Coveralls

@jroberts91 jroberts91 merged commit 0824f18 into CS2103-AY1819S1-F10-1:master Oct 17, 2018
@jroberts91
Copy link
Author

see #94

@jroberts91
Copy link
Author

see #89

@jroberts91 jroberts91 removed the status.Ongoing The issue is currently being worked on. note: remove this label before closing an issue label Oct 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jroberts91 jroberts91

Labels
priority.High Must do type.Epic A big feature which can be broken down into smaller stories e.g. search type.Story A user story
Projects
None yet
Milestone
v1.2
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jroberts91 @coveralls