Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Outdated format for edit in UG #191

Closed
nus-se-bot opened this issue Nov 3, 2018 · 1 comment
Closed

Outdated format for edit in UG #191

nus-se-bot opened this issue Nov 3, 2018 · 1 comment
Assignees
@prokarius
Labels
Documentation Documentation for repo

Comments

@nus-se-bot
Copy link

In DG: edit i/LOAN_INDEX [p/PERSON_NAME] [hp/PERSON_PHONE_NO] [e/PERSON_EMAIL] [r/RATE] [o/OBJECT_IDENTITY]

But in the app

Parameters: INDEX (must be a positive integer) [n/NAME] [ic/NRIC] [p/PHONE] [e/EMAIL] [b/BIKE] [lr/LOANRATE] [t/TAG]...
Example: edit 1 p/91234567 e/johndoe@example.com

Note the absence of i for index, p vs n, etc.

Reported by: @indocomsoft
Severity: High

[original: nus-cs2103-AY1819S1/pe-dry-run#184]
@prokarius prokarius self-assigned this Nov 4, 2018
@prokarius prokarius added the Documentation Documentation for repo label Nov 4, 2018
@prokarius
Copy link
Collaborator

Thank you for pointing that out!
The LoanBook Team will be fixing the UG to better represent the correct usage.

prokarius added a commit that referenced this issue Nov 4, 2018
@prokarius
Fix edit command examples #191 #217
3202164
@prokarius prokarius mentioned this issue Nov 4, 2018
Merged
OrangeJuice7 pushed a commit that referenced this issue Nov 4, 2018
@prokarius @OrangeJuice7
Fix issues in UG examples (#246)
13f8729 
* Fix grammar issues #213, #214

* Remove non implemented non-function features section from UG

* Capitalise Gmail. #207

* Fix grammar issue #199

* Remove unnecessary space #200

* Fix more grammar issues #194 #192 #189 #188

* Fix unnecesary space #181

* Fix punctuation #180 #179

* Remove spaces before colons

* Fix SVA for #198

* Change examples to work when testers are copy pasting #232

* Fix add command examples #219 #216 #186

* Fix edit command examples #191 #217

* Fix incorrectly formatted tip in add documentation #187
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@prokarius prokarius

Labels
Documentation Documentation for repo
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@prokarius @nus-se-bot