Add datafields into Loan class #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 402
💛 - Coveralls |
OrangeJuice7
approved these changes
Oct 24, 2018
There was a problem hiding this comment.
Can update the javadoc for Loan.isSameLoan() to say "Returns true if both loans have the same customer name, NRIC, bike, and at least one other field (Email, Phone, LoanRate, LoanTime)."
Otherwise quite alright. I'll open an issue for the parts which create a new Bike on the spot.
prokarius
reviewed
Oct 24, 2018
| + PREFIX_PHONE + "PHONE " | ||
| + PREFIX_EMAIL + "EMAIL " | ||
| + PREFIX_ADDRESS + "ADDRESS " | ||
| + PREFIX_BIKE + "BIKE " | ||
| + PREFIX_LOANRATE + "LOANRATE " | ||
| + PREFIX_LOANTIME + "LOANTIME " |
There was a problem hiding this comment.
Not correct. Loan start time is NOT a parameter when adding a loan!
The start time based on when the loan was created.
prokarius
reviewed
Oct 24, 2018
| + "[" + PREFIX_PHONE + "PHONE] " | ||
| + "[" + PREFIX_EMAIL + "EMAIL] " | ||
| + "[" + PREFIX_ADDRESS + "ADDRESS] " | ||
| + "[" + PREFIX_BIKE + "BIKE] " | ||
| + "[" + PREFIX_LOANRATE + "LOANRATE] " |
There was a problem hiding this comment.
LoanTime is not supposed to be editable.
There was a problem hiding this comment.
Apologies, I referenced the wrong line. This comment references line 56, which is 1 line below.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For issue: #103