Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add updates to guides #142

Merged
merged 4 commits into from
Oct 28, 2018
Merged

Add updates to guides #142

merged 4 commits into from
Oct 28, 2018

Conversation

prokarius
Copy link
Collaborator

Addresses #141

@prokarius prokarius added this to the v1.4 milestone Oct 28, 2018
@prokarius prokarius self-assigned this Oct 28, 2018
@coveralls
Copy link

coveralls commented Oct 28, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 494

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 91.923%
Totals Coverage Status
Change from base Build 488: 0.0%
Covered Lines: 1969
Relevant Lines: 2142
💛 - Coveralls

OrangeJuice7
OrangeJuice7 reviewed Oct 28, 2018
View reviewed changes
docs/UserGuide.adoc Outdated Show resolved Hide resolved
OrangeJuice7
OrangeJuice7 reviewed Oct 28, 2018
View reviewed changes
docs/UserGuide.adoc Outdated Show resolved Hide resolved
OrangeJuice7
OrangeJuice7 reviewed Oct 28, 2018
View reviewed changes
docs/UserGuide.adoc Outdated Show resolved Hide resolved
OrangeJuice7
OrangeJuice7 reviewed Oct 28, 2018
View reviewed changes
docs/UserGuide.adoc Outdated Show resolved Hide resolved
OrangeJuice7
OrangeJuice7 suggested changes Oct 28, 2018
View reviewed changes
Copy link
Collaborator

@OrangeJuice7 OrangeJuice7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor nits and other slightly-less-minor issues to fix.

The Logic component in the dev guide has not been updated, and diagrams have not been added/updated. You can do it in a separate PR if that's the plan.

Everything else seems fine.

@OrangeJuice7 OrangeJuice7 merged commit ebc7118 into master Oct 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OrangeJuice7 OrangeJuice7 OrangeJuice7 approved these changes

Assignees

@prokarius prokarius

Labels
None yet
Projects
None yet
Milestone
v1.4
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@prokarius @coveralls @OrangeJuice7