Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add password for deletion #96

Merged
merged 5 commits into from
Oct 17, 2018
Merged

Add password for deletion #96

merged 5 commits into from
Oct 17, 2018

Conversation

wn
Copy link

@wn wn commented Oct 17, 2018

Fixes first point of #40

Instead of confirming, require password.

Fix #63

@wn wn requested a review from prokarius October 17, 2018 09:29
@wn wn self-assigned this Oct 17, 2018
@coveralls
Copy link

coveralls commented Oct 17, 2018

Pull Request Test Coverage Report for Build 251

  • 11 of 12 (91.67%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.03%) to 92.473%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/main/java/seedu/address/logic/parser/DeleteCommandParser.java 9 10 90.0%
Totals Coverage Status
Change from base Build 245: -0.03%
Covered Lines: 1548
Relevant Lines: 1674

💛 - Coveralls

+ "Parameters: INDEX (must be a positive integer)\n"
+ "Example: " + COMMAND_WORD + " 1";
+ "Parameters: INDEX (must be a positive integer) and PASSWORD\n"
+ "Example: " + COMMAND_WORD + " i/1 x/12345";
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "parameters" and "example" are not consistent with the other commands. Either do
"Parameters: INDEX (must be a positive integer) PASSWORD\n"
"Example: " + COMMAND_WORD + " 1 12345"
or
"Parameters: " + PREFIX_INDEX + "INDEX (must be a positive integer) " + PREFIX_PASSWORD + "PASSWORD\n"
"Example: " + COMMAND_WORD + " i/1 x/12345"

@wn wn merged commit ca6cfa6 into master Oct 17, 2018
@wn wn added this to the v1.2 milestone Oct 17, 2018
@wn wn deleted the add-pass-to-delete branch October 22, 2018 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants