Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Morph UI and Integrate Anakin components #77

Merged
merged 35 commits into from Oct 17, 2018
Merged

Morph UI and Integrate Anakin components #77

merged 35 commits into from Oct 17, 2018

Conversation

yujiatay
Copy link

@yujiatay yujiatay commented Oct 11, 2018 •
edited

Resolves #67, #109

(Do not close)

@yujiatay yujiatay added status.Ongoing The issue is currently being worked on. note: remove this label before closing an issue. priority.High Must do labels Oct 11, 2018
@yujiatay yujiatay self-assigned this Oct 11, 2018
@yujiatay yujiatay added this to In progress in Project Management via automation Oct 11, 2018
@yujiatay yujiatay added this to the v1.2 milestone Oct 11, 2018
@yujiatay yujiatay changed the title [WIP]: Morph UI [WIP]: Update UI Oct 11, 2018
@coveralls
Copy link

coveralls commented Oct 11, 2018 •
edited

Pull Request Test Coverage Report for Build 170

  • 1 of 50 (2.0%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-1.5%) to 64.555%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/main/java/seedu/address/commons/events/ui/CardPanelSelectionChangedEvent.java 0 5 0.0%
src/main/java/seedu/address/ui/CardCard.java 0 13 0.0%
src/main/java/seedu/address/ui/CardListPanel.java 0 31 0.0%
Totals Coverage Status
Change from base Build 154: -1.5%
Covered Lines: 1437
Relevant Lines: 2226
💛 - Coveralls

@yujiatay yujiatay changed the title [WIP]: Update UI Update UI and Integrate Anakin components Oct 16, 2018
@yujiatay yujiatay added the type.Task Something that needs to be done, but not a story, bug, or an epic. e.g. Move testing code into a new label Oct 16, 2018
@yujiatay yujiatay requested a review from a team October 16, 2018 18:07
@yujiatay yujiatay removed the status.Ongoing The issue is currently being worked on. note: remove this label before closing an issue. label Oct 16, 2018
@yujiatay yujiatay changed the title Update UI and Integrate Anakin components Morph UI and Integrate Anakin components Oct 16, 2018
Project Management automation moved this from In progress to Reviewer approved Oct 17, 2018
kr0stofa
kr0stofa approved these changes Oct 17, 2018
View reviewed changes
Copy link

@kr0stofa kr0stofa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice work!

@yujiatay yujiatay merged commit 752760f into CS2103-AY1819S1-T09-2:master Oct 17, 2018
Project Management automation moved this from Reviewer approved to Done Oct 17, 2018
@yujiatay yujiatay deleted the adapt-ui branch October 25, 2018 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kr0stofa kr0stofa kr0stofa approved these changes

Assignees

@yujiatay yujiatay

Labels
priority.High Must do type.Task Something that needs to be done, but not a story, bug, or an epic. e.g. Move testing code into a new
Projects
Project Management
  
Done
Milestone
v1.2
Development

Successfully merging this pull request may close these issues.

Morph UI component to make it usable with Anakin
3 participants
@yujiatay @coveralls @kr0stofa