Update PPP #192
Merged
Update PPP #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 12, 2018 08:37
jonathantjm
suggested changes
Nov 12, 2018
docs/DeveloperGuide.adoc
Outdated
| * **Alternative 1 (current choice):** Check through all expenses and select those with all the keywords | ||
| ** Pros: Easy to implement. No need to change original architecture. | ||
| ** Cons: Time-consuming. Tend to take longer time when there is a large number of expenses. | ||
| * **Alternative 2:** Store expenses in separated files and only check the relevant files while filtering. |
docs/DeveloperGuide.adoc
Outdated
| * **Alternative 1(current choice):** Filter out the targeted expenses and replace them with edited expenses. | ||
| ** Pros: Easy to implement. Align with current architecture. | ||
| ** Cons: Time-consuming. Tend to take longer time when there is a large number of expenses. | ||
| * **Alternative 2:** Store expenses in separated files. When the expenses are edited, move them |
docs/UserGuide.adoc
Outdated
| * The order of the keywords does not matter, i.e. the KEYWORD `Have lunch` is equivalent to the KEYWORD `lunch have` | ||
| * Partial words will be matched, i.e. using the KEYWORD `Hav` for expense name will an expense with the name `Have` | ||
| * Partial words will be matched, i.e. using the KEYWORD `Hav` for expense name will give an expense with the name `Have` | ||
| * Only `Tag` keywords can have multiple keywords. `Name`/`Category`/`Cost`/`Date` can only have one keywords. |
There was a problem hiding this comment.
Maybe you can give an example of this? i think the user would be quite confused cause a keyword can have multiple words but only tag can have multiple keywords.
then... change the last part to... Name, Category, Cost and Date can only have one keyword
docs/team/jiangchen.adoc
Outdated
| This section summarizes my contribution to the project. | ||
|
|
||
| * *Major enhancement:* | ||
| ** added the ability to find and edit multiple expenses by specific keywords |
|
Also, make sure you rename your PPP to your github username and change the link in AboutUs.adoc accordingly |
jonathantjm
suggested changes
Nov 12, 2018
docs/AboutUs.adoc
Outdated
| @@ -40,7 +40,7 @@ Responsibilities: UI | |||
|
|
|||
| === Jiang Chen | |||
| image::jcjxwy.png[width="150", align="left"] | |||
| {empty}[https://github.com/jcjxwy[github]] [<<jiangchen#, portfolio>>] | |||
| {empty}[https://github.com/jcjxwy[github]] [http://localhost:63342/expense%20tracker%201.2/expense_tracker_1.2/build/docs/html5/team/jcjxwy.html?_ijt=k195lrlr4suj08ud9qlr4i30ht[portfolio]] | |||
There was a problem hiding this comment.
umm i think you just need to change it to <<jcjxwy#, portfolio>>
jonathantjm
approved these changes
Nov 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.