Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated PPP and DG #166

Merged
merged 4 commits into from
Nov 12, 2018
Merged

Updated PPP and DG #166

merged 4 commits into from
Nov 12, 2018

Conversation

wenshei
Copy link

@wenshei wenshei commented Nov 12, 2018

Updated PPP
Modified undo/redo diagrams to match SuperTA

@coveralls
Copy link

Pull Request Test Coverage Report for Build 299

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 80.28%
Totals Coverage Status
Change from base Build 293: 0.0%
Covered Lines: 2805
Relevant Lines: 3494
💛 - Coveralls

yuheong
yuheong approved these changes Nov 12, 2018
View reviewed changes
Copy link

@yuheong yuheong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review: State diagrams for undo/redo have been properly updated to SuperTaClient. Merging changes.

@yuheong yuheong merged commit a21e6b9 into CS2103-AY1819S1-T16-2:master Nov 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuheong yuheong yuheong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wenshei @coveralls @yuheong