Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add deliveryman select #152

Merged
merged 4 commits into from
Nov 5, 2018
Merged

Add deliveryman select #152

merged 4 commits into from
Nov 5, 2018

Conversation

juxd
Copy link

@juxd juxd commented Nov 4, 2018 •
edited
Loading

This PR adds the ability to select specific deliveryman to be displayed in the app using the /deliveryman select command.

Fixes #153

@coveralls
Copy link

Pull Request Test Coverage Report for Build 298

  • 17 of 18 (94.44%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 87.8%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/main/java/seedu/address/logic/parser/deliveryman/DeliverymanCommandParser.java 0 1 0.0%
Totals Coverage Status
Change from base Build 292: 0.2%
Covered Lines: 2821
Relevant Lines: 3213
💛 - Coveralls

@juxd juxd self-assigned this Nov 4, 2018
@kohchihao kohchihao added the v1.4 label Nov 5, 2018
kohchihao
kohchihao approved these changes Nov 5, 2018
View reviewed changes
Copy link

@kohchihao kohchihao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

jinyingtan
jinyingtan approved these changes Nov 5, 2018
View reviewed changes
Copy link

@jinyingtan jinyingtan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 💯

@kohchihao kohchihao merged commit 9c39582 into CS2103-AY1819S1-T16-3:master Nov 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kohchihao kohchihao kohchihao approved these changes

@jinyingtan jinyingtan jinyingtan approved these changes

@rrtheonlyone rrtheonlyone Awaiting requested review from rrtheonlyone

Assignees

@juxd juxd

Labels
v1.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@juxd @coveralls @kohchihao @jinyingtan