Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update UserGuide #163

Merged
merged 1 commit into from
Nov 6, 2018
Merged

Update UserGuide #163

merged 1 commit into from
Nov 6, 2018

Conversation

kohchihao
Copy link

@kohchihao kohchihao commented Nov 5, 2018 •
edited
Loading

In this PR,

  • Updated PASSWORD in Field restrictions
  • Updated /login and /signup to mention about login/signup will lead to same screen for different managers, because they are in the same stall.

fixes #132, #144

@kohchihao kohchihao added the v1.4 label Nov 5, 2018
@kohchihao kohchihao added this to the v1.4 milestone Nov 5, 2018
@kohchihao kohchihao self-assigned this Nov 5, 2018
@coveralls
Copy link

Pull Request Test Coverage Report for Build 314

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 87.637%
Totals Coverage Status
Change from base Build 310: 0.0%
Covered Lines: 2800
Relevant Lines: 3195
💛 - Coveralls

jinyingtan
jinyingtan approved these changes Nov 5, 2018
View reviewed changes
Copy link

@jinyingtan jinyingtan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

juxd
juxd approved these changes Nov 5, 2018
View reviewed changes
Copy link

@juxd juxd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🍌

monmanuela
monmanuela approved these changes Nov 5, 2018
View reviewed changes
Copy link

@monmanuela monmanuela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🏳️‍🌈

@jinyingtan jinyingtan merged commit 655379f into CS2103-AY1819S1-T16-3:master Nov 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juxd juxd juxd approved these changes

@jinyingtan jinyingtan jinyingtan approved these changes

@monmanuela monmanuela monmanuela approved these changes

Assignees

@kohchihao kohchihao

Labels
v1.4
Projects
V1.4
  
Awaiting triage
Milestone
v1.4
Development

Successfully merging this pull request may close these issues.

Display the same set of information for different users
5 participants
@kohchihao @coveralls @juxd @jinyingtan @monmanuela