Fix find command bugs for order and deliveryman #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 406
💛 - Coveralls |
| * Partial match is allowed for name, phone and food. e.g. `alex` will match `alex lim` and `al` will match `alex lim` | ||
| * To find for orders from a specific date, use 1 date field. e.g `dt/01-10-2018 10:00:00` will return order/s on that | ||
| * Partial match is allowed for name, phone, food and address. e.g. `alex` will match `alex lim` and `al` will match `alex lim` | ||
| * When more than 1 fields are given, the find will do an `and` on all fields. e.g. `n/alex p/1234`, will be `n == 'alex' AND p == 1234` |
There was a problem hiding this comment.
Maybe can state here that date is an exception?
Like e.g. except for date field. Refer below for how that works
There was a problem hiding this comment.
It stated on line 252 to 259. Or is it still unclear?
There was a problem hiding this comment.
No its okay! I thought you could maybe signpost here as well (so people who sometimes dont read the whole thing are aware)
rrtheonlyone
approved these changes
Nov 11, 2018
added 7 commits
November 12, 2018 10:33
jinyingtan
force-pushed
the
Find-Bugs
branch
from
eea5976
to
1797448
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Fixes: #191
Fixes: #192