Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add assign limit #197

Merged
merged 4 commits into from
Nov 12, 2018
Merged

Add assign limit #197

merged 4 commits into from
Nov 12, 2018

Conversation

juxd
Copy link

@juxd juxd commented Nov 11, 2018

Fixes #186.

@juxd juxd added enhancement New feature or request good first issue Good for newcomers v1.4 labels Nov 11, 2018
@juxd juxd added this to the v1.4 milestone Nov 11, 2018
@juxd juxd self-assigned this Nov 11, 2018
@coveralls
Copy link

coveralls commented Nov 11, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 415

  • 8 of 13 (61.54%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.1%) to 87.678%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/main/java/seedu/address/model/deliveryman/Deliveryman.java 2 3 66.67%
src/main/java/seedu/address/logic/commands/AssignCommand.java 4 6 66.67%
src/main/java/seedu/address/model/deliveryman/exceptions/OrdersLimitExceededException.java 0 2 0.0%
Totals Coverage Status
Change from base Build 413: -0.1%
Covered Lines: 2889
Relevant Lines: 3295
💛 - Coveralls

rrtheonlyone
rrtheonlyone approved these changes Nov 12, 2018
View reviewed changes
Copy link

@rrtheonlyone rrtheonlyone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

kohchihao
kohchihao approved these changes Nov 12, 2018
View reviewed changes
Copy link

@kohchihao kohchihao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚈 Now we cant assign more than 5 orders to our deliveryman

monmanuela
monmanuela approved these changes Nov 12, 2018
View reviewed changes
Copy link

@monmanuela monmanuela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

jinyingtan
jinyingtan approved these changes Nov 12, 2018
View reviewed changes
Copy link

@jinyingtan jinyingtan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rrtheonlyone rrtheonlyone merged commit d57f2de into CS2103-AY1819S1-T16-3:master Nov 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kohchihao kohchihao kohchihao approved these changes

@rrtheonlyone rrtheonlyone rrtheonlyone approved these changes

@jinyingtan jinyingtan jinyingtan approved these changes

@monmanuela monmanuela monmanuela approved these changes

Assignees

@juxd juxd

Labels
enhancement New feature or request good first issue Good for newcomers v1.4
Projects
V1.4
  
Awaiting triage
Milestone
v1.4
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@juxd @coveralls @kohchihao @rrtheonlyone @jinyingtan @monmanuela