Volunteer Management #116
Volunteer Management #116
Conversation
afiqlattif
added
the
status.Ongoing
|
|
||
| // Identity fields | ||
| private final VolunteerId volunteerId; | ||
| private final Name name; |
There was a problem hiding this comment.
Remember to include the following fields for volunteers!
- Birthday
- Gender
There was a problem hiding this comment.
Added Gender and Birthday classes, but have yet to implement the correct methods.
…teer parser files
…olunteerAddressBook.xml to XmlAddressBookStorageTest
afiqlattif
added
status.Ready
| + PREFIX_VOLUNTEER_EMAIL + "johnd@example.com " | ||
| + PREFIX_VOLUNTEER_ADDRESS + "311, Clementi Ave 2, #02-25 " | ||
| + PREFIX_VOLUNTEER_TAG + "friends " | ||
| + PREFIX_VOLUNTEER_TAG + "owesMoney"; |
There was a problem hiding this comment.
Might want to change the second tag to fit a volunteer's context instead.
Instead of 'owed money', a tag which says 'driver' would be better. (In the context of volunteer)
|
|
||
| public static final String MESSAGE_EDIT_VOLUNTEER_SUCCESS = "Edited Volunteer: %1$s"; | ||
| public static final String MESSAGE_NOT_EDITED = "At least one field to edit must be provided."; | ||
| public static final String MESSAGE_DUPLICATE_VOLUNTEER = "This volunteer already exists in the address book."; |
There was a problem hiding this comment.
Change address book to something like
"This volunteer already exists in the application"
| /** | ||
| * Selects a person identified using it's displayed index from the address book. | ||
| */ | ||
| public class ManageVolunteerCommand extends Command { |
There was a problem hiding this comment.
Volunteers do not need a manage command. Manage is just used in the event's context to switch to the record context.
| /** | ||
| * Parses input arguments and creates a new SelectVolunteerCommand object | ||
| */ | ||
| public class ManageVolunteerCommandParser implements Parser<ManageVolunteerCommand> { |
There was a problem hiding this comment.
Again, this class is not needed for the volunteers :)
| new Birthday("02-10-1996"), new VolunteerPhone("87438807"), | ||
| new VolunteerEmail("alexyeoh@example.com"), | ||
| new VolunteerAddress("Blk 30 Geylang Street 29, #06-40"), | ||
| getTagSet("friends")), |
There was a problem hiding this comment.
Try to use tags related to volunteers instead!!
| /* | ||
| * Gender must only be male or female | ||
| */ | ||
| public static final String GENDER_MALE_VALIDATION_REGEX = "male"; |
There was a problem hiding this comment.
Do we want users to enter the whole word? 'Male and Female'. Or should we allow them to type 'M' and 'F' for convenience. Then when storing and retrieving, we can always do a if-else to convert the char to the whole word.
No description provided.