Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DeveloperGuide.adoc: Update certificate export implementation section #130

Merged
merged 5 commits into from
Oct 18, 2018
Merged

DeveloperGuide.adoc: Update certificate export implementation section #130

merged 5 commits into from
Oct 18, 2018

Conversation

sharan8
Copy link

@sharan8 sharan8 commented Oct 17, 2018

  • Added border and label to sample certificate
  • Added [Coming in V1.3] tag
  • Organised pros and cons into neat tables

@sharan8 sharan8 added this to the CS2101 UGDG Draft 1 milestone Oct 17, 2018
@coveralls
Copy link

coveralls commented Oct 17, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 78.484% when pulling d48ea4a on sharan8:exportcert-developerguide into 7737044 on CS2103-AY1819S1-W16-2:master.

@sharan8 sharan8 added the status.Ready The PR is ready to be reviewed. note: remove this label before merging a PR. label Oct 17, 2018
@iMarbles iMarbles merged commit a287cc3 into CS2103-AY1819S1-W16-2:master Oct 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afiqlattif afiqlattif Awaiting requested review from afiqlattif

@Scrubbius Scrubbius Awaiting requested review from Scrubbius

Assignees
No one assigned
Labels
status.Ready The PR is ready to be reviewed. note: remove this label before merging a PR.
Projects
None yet
Milestone
CS2101 UGDG Draft 1
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sharan8 @coveralls @iMarbles @AmabelYeo