Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Volunteer Management #146

Merged
merged 29 commits into from
Oct 24, 2018
Merged

Conversation

afiqlattif
Copy link

Have yet to implement the tests for Volunteer class and configuration of IC number as volunteerID

@afiqlattif afiqlattif added the status.Ready The PR is ready to be reviewed. note: remove this label before merging a PR. label Oct 23, 2018
@afiqlattif afiqlattif added this to the v1.3 milestone Oct 23, 2018
@afiqlattif afiqlattif added status.Ongoing The issue is currently being worked on. note: remove this label before closing an issue. and removed status.Ready The PR is ready to be reviewed. note: remove this label before merging a PR. labels Oct 23, 2018
…to afiqlattif-add-volunteer

# Conflicts:
#	docs/DeveloperGuide.adoc
#	src/main/java/seedu/address/commons/core/Messages.java
#	src/main/java/seedu/address/logic/Logic.java
#	src/main/java/seedu/address/logic/LogicManager.java
#	src/main/java/seedu/address/logic/commands/RedoCommand.java
#	src/main/java/seedu/address/logic/commands/UndoCommand.java
#	src/main/java/seedu/address/logic/parser/AddressBookParser.java
#	src/main/java/seedu/address/model/AddressBook.java
#	src/main/java/seedu/address/model/Model.java
#	src/main/java/seedu/address/model/ModelManager.java
#	src/main/java/seedu/address/model/ReadOnlyAddressBook.java
#	src/main/java/seedu/address/model/util/SampleDataUtil.java
#	src/main/java/seedu/address/model/volunteer/Gender.java
#	src/main/java/seedu/address/model/volunteer/Volunteer.java
#	src/main/java/seedu/address/storage/XmlAdaptedVolunteer.java
#	src/main/java/seedu/address/storage/XmlSerializableAddressBook.java
#	src/main/java/seedu/address/ui/MainWindow.java
#	src/test/data/XmlAddressBookStorageTest/invalidAndValidVolunteerAddressBook.xml
#	src/test/data/XmlAddressBookStorageTest/invalidVolunteerAddressBook.xml
#	src/test/data/XmlSerializableAddressBookTest/duplicateVolunteerAddressBook.xml
#	src/test/data/XmlSerializableAddressBookTest/invalidVolunteerAddressBook.xml
#	src/test/data/XmlSerializableAddressBookTest/typicalVolunteersAddressBook.xml
#	src/test/data/XmlUtilTest/invalidVolunteerField.xml
#	src/test/data/XmlUtilTest/missingVolunteerField.xml
#	src/test/data/XmlUtilTest/validVolunteer.xml
#	src/test/java/seedu/address/commons/util/XmlUtilTest.java
#	src/test/java/seedu/address/logic/LogicManagerTest.java
#	src/test/java/seedu/address/logic/commands/AddCommandIntegrationTest.java
#	src/test/java/seedu/address/logic/commands/AddCommandTest.java
#	src/test/java/seedu/address/logic/commands/ClearCommandTest.java
#	src/test/java/seedu/address/logic/commands/CommandTestUtil.java
#	src/test/java/seedu/address/logic/commands/DeleteCommandTest.java
#	src/test/java/seedu/address/logic/commands/EditCommandTest.java
#	src/test/java/seedu/address/logic/commands/EditVolunteerDescriptorTest.java
#	src/test/java/seedu/address/logic/commands/FindCommandTest.java
#	src/test/java/seedu/address/logic/commands/ListCommandTest.java
#	src/test/java/seedu/address/logic/commands/RedoCommandTest.java
#	src/test/java/seedu/address/logic/commands/SelectCommandTest.java
#	src/test/java/seedu/address/logic/commands/UndoCommandTest.java
#	src/test/java/seedu/address/logic/parser/AddressBookParserTest.java
#	src/test/java/seedu/address/model/AddressBookTest.java
#	src/test/java/seedu/address/model/ModelManagerTest.java
#	src/test/java/seedu/address/model/VersionedAddressBookTest.java
#	src/test/java/seedu/address/model/volunteer/AddressTest.java
#	src/test/java/seedu/address/storage/XmlAdaptedVolunteerTest.java
#	src/test/java/seedu/address/storage/XmlSerializableAddressBookTest.java
#	src/test/java/seedu/address/testutil/AddressBookBuilder.java
#	src/test/java/seedu/address/testutil/EditVolunteerDescriptorBuilder.java
#	src/test/java/seedu/address/testutil/TypicalVolunteers.java
#	src/test/java/seedu/address/testutil/VolunteerBuilder.java
#	src/test/java/seedu/address/testutil/VolunteerUtil.java
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 78.19% when pulling 1f2069d on afiqlattif:add-volunteer into f3d51fa on CS2103-AY1819S1-W16-2:master.

@afiqlattif afiqlattif added status.Ready The PR is ready to be reviewed. note: remove this label before merging a PR. and removed status.Ongoing The issue is currently being worked on. note: remove this label before closing an issue. labels Oct 23, 2018
@iMarbles iMarbles merged commit 1b23ae5 into CS2103-AY1819S1-W16-2:master Oct 24, 2018
@afiqlattif afiqlattif deleted the add-volunteer branch October 25, 2018 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status.Ready The PR is ready to be reviewed. note: remove this label before merging a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants