Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exportcert final updates #256

Merged
merged 5 commits into from
Nov 12, 2018

Conversation

sharan8
Copy link

@sharan8 sharan8 commented Nov 12, 2018

Exported certificate is updated to include:

  • Border
  • Event ID
  • Total hours served by the volunteer

Implementation logic is now improved to account for:

  • More than 20 events overrunning the page. This is done by limiting the number of records displayed to 20 and truncating the rest.
  • Long event names. They are truncated as well, to ensure that the record entry doesn't exceed the width of the certificated.

CertGenerator class is refactored to break down the pdf population into several methods, and making better use of shared class fields.

@sharan8 sharan8 added this to the v1.4 milestone Nov 12, 2018
@coveralls
Copy link

coveralls commented Nov 12, 2018

Coverage Status

Coverage increased (+0.2%) to 67.846% when pulling 255bf10 on sharan8:exportcert-command into 4886b00 on CS2103-AY1819S1-W16-2:master.

@sharan8 sharan8 changed the title Update exported certificate exportcert final updates Nov 12, 2018
@sharan8 sharan8 added status.Ongoing The issue is currently being worked on. note: remove this label before closing an issue. status.Ready The PR is ready to be reviewed. note: remove this label before merging a PR. and removed status.Ongoing The issue is currently being worked on. note: remove this label before closing an issue. labels Nov 12, 2018
@iMarbles iMarbles merged commit 37055c6 into CS2103-AY1819S1-W16-2:master Nov 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status.Ready The PR is ready to be reviewed. note: remove this label before merging a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants