Initial Refactoring from Addressbook to MediTabs #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonathanLeeWH
approved these changes
Feb 21, 2019
There was a problem hiding this comment.
Good job in refactoring. You have put in quite a lot of effort to ensure the refactoring does not affect the underlying architecture and structure of the program. Keep up the good work. I have rerun the build to fix the initial build errors. The builds now show pass. I will approve this PR and merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed Person, Address, Phone, Email classes to Medicine, Company, Quantity, Expiry classes respectively.
Changed test case data to better suit MediTabs such as using medicine names instead of person names.
No change to functionality except for regex validation which was changed to suit the new fields.
UserGuide formatting changed to address Travis warnings