[mid v1.2] Add more validation to UpdateCommand #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flxffy
reviewed
Mar 13, 2019
|
|
||
| if (batchToUpdate != null) { | ||
| quantity -= batchToUpdate.getQuantity().getNumericValue(); | ||
| } | ||
| quantity += updatedBatch.getQuantity().getNumericValue(); | ||
|
|
||
| if (quantity > 999999999) { |
There was a problem hiding this comment.
Use Java's Integer.MAX_VALUE if the intention is to prevent integer overflow.
There was a problem hiding this comment.
You're right! Thanks for pointing it out. I will amend it by next PR.
flxffy
approved these changes
Mar 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add max quantity to prevent integer overflow.
Add check to UpdateCommand to prevent removing medicine that does not exist.
Improve performance of getNewMedicineExpiry for UpdateCommand class to O(1) most of the time
List stays on current view for more convenient updating after using UpdateCommand.
Improve and add JUnit tests for UpdateCommand
Also removed Address Book Mode and Kevin's part of the user guides to be replaced with more coherent features in future update of UseGuide.