Complete Remaining AutoTests #217

ptvrajsk · 2019-04-03T15:30:21Z

No description provided.

WeiTangLau · 2019-04-06T04:07:44Z

ptvrajsk · 2019-04-11T06:06:43Z

AutoTest Approach

Workflow

Before starting on ANY of the test files, please make a comment in this issue stating clearly which test file you are starting to work on so that we can easily track each others progress and avoid having 2 people working on the same test file at the same time.
Make Incremental commits on each test file. Every commit should only contain changes tied to one test file. (e.g. changes to CommandTestUtil.java & AddCommandTest.java can be under the same commit if your changes in CommandTestUtil.java is to allow AddCommandTest.java to work. So this commit will be considered as changes for the AddCommandTest.java to work.)
After completing each test file (after confirming that it works and passes all style checks). Ensure that your commit message contains the Complete Remaining AutoTests #217 so that Github automatically links your commit to this issue. Should there be any code problems this will allow us to refer to the problem and fix it easily.
NOTE: DO NOT include the statement resolve: #217 or resolves: #217 in your commits or PR because Github will automatically close this issue if you do.
After your PR has been reviewed and merge, return to this issue and tick off the task that you have completed in Complete Remaining AutoTests #217 (comment). Again, this will just assist house keeping.

NOTE: There maybe some test cases that work right out the box. In that case you can lump them together in a single commit. So for example if TestA and TestB is already working but TestC is not. When making changes to TestC we can just put that Verified TestA & TestB working. Working on TestC along those lines.

Deadline

We should try to get this done BY Friday (12 April 2019). So that we have the weekend to settle UG, DG & PPP.

ptvrajsk · 2019-04-11T06:12:09Z

~~I'm currently starting NameTest, SizeTest & DirectoryTest. (model.pdf Package)~~
~~Awaiting PR Merger~~
Merged

From prior testing, the NameTest already works (implementation in v1.3 of pdf++). SizeTest however was incomplete. Fixed and revamped the test format to get it to work. SizeTest now works completely HOWEVER. From the trial demo, it was highlighted that we should make the size value more "readable" and this will require several changes in the Size, JsonAdaptedPdf and other class files. Proceeding to work on those changes now. Track Changes: CS2103-AY1819S2-T12-4#217

SizeTest is now comprehensive and complete. This commit contains some checkstyle fixes for Travis Erros that appeared in the previous commit (Pdf.java javadoc missing). Also implemented the use of static variables for threshold and prefix values so that any changes made will be easily ported over to the test cases. One minor change was to make the regex check in the Size.java a private static variable as per IntelliJ's recommendation. Track issue: CS2103-AY1819S2-T12-4#217

Completed the Directory Tests. Changes done to CommandTestUtil to include cases for DirectoryTest.java. Made some changes to the build.gradle and and travis.yml to begin including working test cases to see if coveralls is working. Track issue: CS2103-AY1819S2-T12-4#217

ptvrajsk · 2019-04-11T09:19:21Z

~~Currently working on NameContainsKeywordsTest, DeadlineTest, Unique PdfListTest, TagTest~~
~~Awaiting PR Merger~~
Merged

Streamlined Sized test to use bitwise shift for more optimized operations. NameContainsKeywordsPredicateTest is still working from its implementation in v1.3. Minor change to travis.yml, it would seem that only running nonGuiTests still did not trigger coverage. Hence current implementation triggers allTests but manually disables ui tests within build.gradle. Track Issue: CS2103-AY1819S2-T12-4#217

WeiTangLau · 2019-04-11T10:32:00Z

~~I am currently working PdfTest & ModelManagerTest~~
Merged

Set of tests for UniquePdfListTest.java is fully working. Moving on to work on TagTest as well as other ModelTests. Track Issue: CS2103-AY1819S2-T12-4#217

Added enhancements to TagTest.java and it is now in a fully working state. This commit includes some checkstyle fixes to address issues raised by Travis in the last comit. Track Issue: CS2103-AY1819S2-T12-4#217

Preliminary rounds of test creation complete for deadline class. Track Issue: CS2103-AY1819S2-T12-4#217

ptvrajsk · 2019-04-11T11:57:05Z

~~Currently working on UserPrefsTest & PdfBookTest & VersionedPdfBookTest~~
Merged

Minor changes to UserPrefsTest (Naming Convention Changes) and rework of the PdfBookTest, both are now in working condition. Track Issue: CS2103-AY1819S2-T12-4#217

Fixed the VersionedPdfBookTest. Track Issue: CS2103-AY1819S2-T12-4#217

Track Issue: CS2103-AY1819S2-T12-4#217

ptvrajsk · 2019-04-11T14:26:58Z

~~Starting JsonAdaptedPdfTest & JsonPdfBookStorageTest~~
Merged

Revamped the above test to bring it to a working state, reference CS2103-AY1819S2-T12-4#217.

Reference CS2103-AY1819S2-T12-4#217

Moving some variables to CommandTestUtil. Reference CS2103-AY1819S2-T12-4#217

Revamped and got the above test to work. Reference CS2103-AY1819S2-T12-4#217.

Test case for DeleteCommandParser. see: CS2103-AY1819S2-T12-4#217

Provided test cases for EditCommandParser. see : CS2103-AY1819S2-T12-4#217

With some changes to the test json files, managed to fix the serializable pdf book test. Reference: CS2103-AY1819S2-T12-4#217

Minor changes to file, currently in passing state. Reference: CS2103-AY1819S2-T12-4#217

StorageManagerTest working out of the box, implemented some naming convention changes across the storage unit and included the storage tests in build.gradle. Expect Coverage increase. Reference: CS2103-AY1819S2-T12-4#217

Json files require legitimate files hence, unable to preset them in the test json file that is uploaded to travis. Travis would always show it as failing. Hence removed that test. Reference: CS2103-AY1819S2-T12-4#217

jetkan-yk · 2019-04-12T11:36:36Z

Currently working on deadlineCommandTest

ptvrajsk · 2019-04-12T12:49:08Z

~~Working on TagCommandTest & TagCommandParserTest~~
Merged

TagCommand brought to skeletal working state. Reference: CS2103-AY1819S2-T12-4#217

Provided test cases for PdfBookParser. See: CS2103-AY1819S2-T12-4#217

Implemented a working version of the TagCommandParserTest. Reference CS2103-AY1819S2-T12-4#217.

Track issue: CS2103-AY1819S2-T12-4#217

Provided test cases for TagContainsKeywordsPredicate. See: CS2103-AY1819S2-T12-4#217

ptvrajsk added type.Epic A big feature which can be broken down into smaller stories e.g. search priority.High labels Apr 3, 2019

ptvrajsk added this to the v1.4 milestone Apr 3, 2019

ptvrajsk assigned lormee94, jetkan-yk, ptvrajsk and WeiTangLau Apr 11, 2019

ptvrajsk added the status.Ongoing The issue is currently being worked on. note: remove this label before closing an issue. label Apr 11, 2019

ptvrajsk mentioned this issue Apr 11, 2019

(v1.4) SizeTest Streamlining #271

Merged

ptvrajsk added a commit to ptvrajsk/main that referenced this issue Apr 11, 2019

(v1.4) UniquePdfListTest.java working

7a7c3f8

Set of tests for UniquePdfListTest.java is fully working. Moving on to work on TagTest as well as other ModelTests. Track Issue: CS2103-AY1819S2-T12-4#217

ptvrajsk added a commit to ptvrajsk/main that referenced this issue Apr 11, 2019

(v1.4) Completed DeadlineTest

ceab204

Preliminary rounds of test creation complete for deadline class. Track Issue: CS2103-AY1819S2-T12-4#217

WeiTangLau mentioned this issue Apr 11, 2019

v1.4 tests #274

Merged

ptvrajsk added a commit to ptvrajsk/main that referenced this issue Apr 11, 2019

(v1.4) Working VersionedPdfBookTest

bf465fc

Fixed the VersionedPdfBookTest. Track Issue: CS2103-AY1819S2-T12-4#217

ptvrajsk added a commit to ptvrajsk/main that referenced this issue Apr 11, 2019

Merge branch 'master' into AutoTest

1ade70b

Track Issue: CS2103-AY1819S2-T12-4#217

ptvrajsk added a commit to ptvrajsk/main that referenced this issue Apr 11, 2019

(v1.4) Add Commons & Model test to coverage

c853ec2

Track Issue: CS2103-AY1819S2-T12-4#217

WeiTangLau closed this as completed in 625d9d3 Apr 11, 2019

ptvrajsk reopened this Apr 11, 2019

ptvrajsk added a commit to ptvrajsk/main that referenced this issue Apr 12, 2019

(v1.4) JsonAdaptedPdfTest Complete

a4b1b2d

Revamped the above test to bring it to a working state, reference CS2103-AY1819S2-T12-4#217.

ptvrajsk added a commit to ptvrajsk/main that referenced this issue Apr 12, 2019

Merge branch 'master' into AutoTest

f55b8e3

Reference CS2103-AY1819S2-T12-4#217

ptvrajsk added a commit to ptvrajsk/main that referenced this issue Apr 12, 2019

Checkstyle Fixes + Code Optimisation

29abbca

Moving some variables to CommandTestUtil. Reference CS2103-AY1819S2-T12-4#217

ptvrajsk added a commit to ptvrajsk/main that referenced this issue Apr 12, 2019

JsonPdfBookStorageTest Working

24f9975

Revamped and got the above test to work. Reference CS2103-AY1819S2-T12-4#217.

WeiTangLau added a commit to WeiTangLau/main that referenced this issue Apr 12, 2019

(v1.4) DeleteCommandParserTest

ba48ffc

Test case for DeleteCommandParser. see: CS2103-AY1819S2-T12-4#217

WeiTangLau added a commit to WeiTangLau/main that referenced this issue Apr 12, 2019

(v1.4) EditCommandParserTest

d980a49

Provided test cases for EditCommandParser. see : CS2103-AY1819S2-T12-4#217

ptvrajsk added a commit to ptvrajsk/main that referenced this issue Apr 12, 2019

(v1.4) Fixed JsonSerializablePdfBookTest

f98a1e0

With some changes to the test json files, managed to fix the serializable pdf book test. Reference: CS2103-AY1819S2-T12-4#217

ptvrajsk added a commit to ptvrajsk/main that referenced this issue Apr 12, 2019

(v1.4) Fixed JsonUserPrefsStorageTest

9e3bb82

Minor changes to file, currently in passing state. Reference: CS2103-AY1819S2-T12-4#217

ptvrajsk added a commit to ptvrajsk/main that referenced this issue Apr 12, 2019

(v1.4) TagCommand

b783e39

TagCommand brought to skeletal working state. Reference: CS2103-AY1819S2-T12-4#217

WeiTangLau added a commit to WeiTangLau/main that referenced this issue Apr 12, 2019

(v1.4) PdfBookParserTest

4de2487

Provided test cases for PdfBookParser. See: CS2103-AY1819S2-T12-4#217

ptvrajsk added a commit to ptvrajsk/main that referenced this issue Apr 12, 2019

(v1.4) TagCommandParserTest Complete

b3965eb

Implemented a working version of the TagCommandParserTest. Reference CS2103-AY1819S2-T12-4#217.

jetkan-yk added a commit to jetkan-yk/main that referenced this issue Apr 12, 2019

Update DeadlineCommand Test

83ac15b

Track issue: CS2103-AY1819S2-T12-4#217

jetkan-yk added a commit to jetkan-yk/main that referenced this issue Apr 12, 2019

Update DeadlineCommandParser Autotests

8cd43a8

Track issue: CS2103-AY1819S2-T12-4#217

jetkan-yk mentioned this issue Apr 12, 2019

Update DeadlineCommandParser Autotest #286

Merged

WeiTangLau added a commit to WeiTangLau/main that referenced this issue Apr 13, 2019

(v1.4)TagContainsKeywordsPredicateTest

f19b0c4

Provided test cases for TagContainsKeywordsPredicate. See: CS2103-AY1819S2-T12-4#217

WeiTangLau mentioned this issue Apr 13, 2019

(v1.4) TagContainsKeywordsPredicateTest #293

Merged

jetkan-yk closed this as completed Apr 15, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Complete Remaining AutoTests #217

Complete Remaining AutoTests #217

ptvrajsk commented Apr 3, 2019

WeiTangLau commented Apr 6, 2019 •

edited by jetkan-yk

ptvrajsk commented Apr 11, 2019 •

edited

ptvrajsk commented Apr 11, 2019 •

edited

ptvrajsk commented Apr 11, 2019 •

edited

WeiTangLau commented Apr 11, 2019 •

edited by ptvrajsk

ptvrajsk commented Apr 11, 2019 •

edited

ptvrajsk commented Apr 11, 2019 •

edited

jetkan-yk commented Apr 12, 2019

ptvrajsk commented Apr 12, 2019 •

edited

Complete Remaining AutoTests #217

Complete Remaining AutoTests #217

Comments

ptvrajsk commented Apr 3, 2019

WeiTangLau commented Apr 6, 2019 • edited by jetkan-yk

Command Package [Tackled by: @jetkan-yk @WeiTangLau @ptvrajsk]

Command Parser Package [Tackled By: @WeiTangLau]

Logic Test [Tackled By: @jetkan-yk ]

Storage Test [Tackled by @ptvrajsk]

model Package [Tackled By: @ptvrajsk @WeiTangLau ]

model.tag Package [Tackled By: @ptvrajsk]

model.pdf Package [Tackled By: @ptvrajsk & @WeiTangLau ]

ptvrajsk commented Apr 11, 2019 • edited

AutoTest Approach

Workflow

Deadline

ptvrajsk commented Apr 11, 2019 • edited

ptvrajsk commented Apr 11, 2019 • edited

WeiTangLau commented Apr 11, 2019 • edited by ptvrajsk

ptvrajsk commented Apr 11, 2019 • edited

ptvrajsk commented Apr 11, 2019 • edited

jetkan-yk commented Apr 12, 2019

ptvrajsk commented Apr 12, 2019 • edited

WeiTangLau commented Apr 6, 2019 •

edited by jetkan-yk

ptvrajsk commented Apr 11, 2019 •

edited

ptvrajsk commented Apr 11, 2019 •

edited

ptvrajsk commented Apr 11, 2019 •

edited

WeiTangLau commented Apr 11, 2019 •

edited by ptvrajsk

ptvrajsk commented Apr 11, 2019 •

edited

ptvrajsk commented Apr 11, 2019 •

edited

ptvrajsk commented Apr 12, 2019 •

edited