Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created AddRequestCommand #70

Merged

Conversation

daviddl9
Copy link

Created an AddRequestCommand that parses in user input to create Request objects.

Updated storage component to create a RequestBook.json file to store Request objects.

Updated model, logic and storage components to handle the logic of parsing in the string and writing into the RequestBook.json file.

@daviddl9 daviddl9 added type.Epic A big feature which can be broken down into smaller stories e.g. search priority.High Must do labels Mar 13, 2019
@daviddl9 daviddl9 added this to the v1.2 milestone Mar 13, 2019
@jing1324
Copy link

Just take note, all files such as addressbook.json and requestbook.json are included inside the .gitignore by default and will not be shown in changes. It is recommended that everyone has their own version of the data otherwise it will cause a merge conflict every time someone pushes code since everyone's version of the data file will be somewhat different.

Copy link

@jing1324 jing1324 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read my note. Otherwise everything else is good.

Copy link

@Lookuz Lookuz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good, I like it!

@daviddl9
Copy link
Author

ok!

@daviddl9 daviddl9 merged commit 2a06912 into CS2103-AY1819S2-W09-2:master Mar 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority.High Must do type.Epic A big feature which can be broken down into smaller stories e.g. search
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants