Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Offline mode: Resolve links to absolute form when adding articles #102

Merged
merged 6 commits into from
Mar 27, 2019
Merged

Offline mode: Resolve links to absolute form when adding articles #102

merged 6 commits into from
Mar 27, 2019

Conversation

thomastanck
Copy link

Resolves #99.

Summary of changes

  • Minor refactors:
    • TemporaryStorageManager that makes a Storage which actually works
    • Rename .network to .util
  • Add the document converter that resolves links
  • Make add command use the document converter prior to saving the article

Part of epics

@thomastanck thomastanck added this to the v1.3 milestone Mar 24, 2019
@coveralls
Copy link

coveralls commented Mar 24, 2019 •
edited

Pull Request Test Coverage Report for Build 410

  • 18 of 20 (90.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 92.727%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/main/java/seedu/address/util/AbsoluteUrlDocumentConverter.java 16 18 88.89%
Totals Coverage Status
Change from base Build 385: 0.1%
Covered Lines: 1785
Relevant Lines: 1925
💛 - Coveralls

epicfailname
epicfailname approved these changes Mar 26, 2019
View reviewed changes
Copy link

@epicfailname epicfailname left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thomastanck thomastanck merged commit 352ff26 into CS2103-AY1819S2-W10-1:master Mar 27, 2019
@thomastanck thomastanck deleted the offline-links branch March 27, 2019 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@epicfailname epicfailname epicfailname approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.3
Development

Successfully merging this pull request may close these issues.

Offline support: Resolve relative links to absolute links in downloaded web pages
3 participants
@thomastanck @coveralls @epicfailname