Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Depends on #111] Delete articles from disk when deleted or archived #113

Merged
merged 6 commits into from
Apr 2, 2019
Merged

[Depends on #111] Delete articles from disk when deleted or archived #113

merged 6 commits into from
Apr 2, 2019

Conversation

thomastanck
Copy link

@thomastanck thomastanck commented Apr 1, 2019 •
edited

Depends on #111.
Resolves #70.

Summary of changes

  • Slight refactor to move article saving to addListEntry to ensure that all places where entries are added to the reading list will be accompanied by some appropriate article content to save.
  • Delete articles when they are deleted.

Part of epics:

@thomastanck thomastanck changed the title Delete articles from disk when deleted or archived [Depends on #111] Delete articles from disk when deleted or archived Apr 1, 2019
@thomastanck thomastanck added type.Story A user story priority.Medium Nice to have labels Apr 1, 2019
@thomastanck thomastanck added this to the v1.3 milestone Apr 1, 2019
@coveralls
Copy link

coveralls commented Apr 1, 2019 •
edited

Pull Request Test Coverage Report for Build 532

  • 55 of 57 (96.49%) changed or added relevant lines in 12 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.08%) to 88.074%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/main/java/seedu/address/model/ModelManager.java 10 12 83.33%
Totals Coverage Status
Change from base Build 526: -0.08%
Covered Lines: 1994
Relevant Lines: 2264
💛 - Coveralls

epicfailname
epicfailname approved these changes Apr 2, 2019
View reviewed changes
Copy link

@epicfailname epicfailname left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thomastanck thomastanck merged commit 5fbcbb2 into master Apr 2, 2019
@thomastanck thomastanck deleted the offline-delete branch April 2, 2019 13:33
rlrh added a commit that referenced this pull request Apr 2, 2019
@rlrh
Merge pull request #116 from rlrh/refactor-add-command
372ed96 
[Depends on #113] Refactor AddCommand
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@epicfailname epicfailname epicfailname approved these changes

Assignees
No one assigned
Labels
priority.Medium Nice to have type.Story A user story
Projects
None yet
Milestone
v1.3
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@thomastanck @coveralls @epicfailname