Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feeds Management and Subscription #114

Merged
merged 27 commits into from
Apr 2, 2019
Merged

Feeds Management and Subscription #114

merged 27 commits into from
Apr 2, 2019

Conversation

qjqqyy
Copy link

@qjqqyy qjqqyy commented Apr 1, 2019

builds on #107

Summary of changes

Part of epics

@qjqqyy qjqqyy added this to the v1.3 milestone Apr 1, 2019
@qjqqyy qjqqyy mentioned this pull request Apr 2, 2019
@qjqqyy qjqqyy marked this pull request as ready for review April 2, 2019 09:28
@coveralls
Copy link

coveralls commented Apr 2, 2019

Pull Request Test Coverage Report for Build 596

  • 61 of 168 (36.31%) changed or added relevant lines in 16 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-3.5%) to 84.469%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/main/java/seedu/address/storage/StorageManager.java 14 16 87.5%
src/main/java/seedu/address/logic/parser/SubscribeCommandParser.java 0 3 0.0%
src/main/java/seedu/address/MainApp.java 11 15 73.33%
src/main/java/seedu/address/model/UserPrefs.java 5 9 55.56%
src/main/java/seedu/address/logic/parser/RefreshCommandParser.java 0 6 0.0%
src/main/java/seedu/address/logic/parser/UnsubscribeCommandParser.java 0 6 0.0%
src/main/java/seedu/address/logic/parser/EntryBookFeedsParser.java 1 12 8.33%
src/main/java/seedu/address/logic/commands/UnsubscribeCommand.java 0 12 0.0%
src/main/java/seedu/address/model/ModelManager.java 9 23 39.13%
src/main/java/seedu/address/logic/commands/SubscribeCommand.java 0 22 0.0%
Files with Coverage Reduction New Missed Lines %
src/main/java/seedu/address/storage/StorageManager.java 1 89.19%
Totals Coverage Status
Change from base Build 583: -3.5%
Covered Lines: 1996
Relevant Lines: 2363

💛 - Coveralls

Copy link

@epicfailname epicfailname left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants