Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Google News search command #121

Merged
merged 6 commits into from
Apr 2, 2019
Merged

Add Google News search command #121

merged 6 commits into from
Apr 2, 2019

Conversation

rlrh
Copy link

@rlrh rlrh commented Apr 2, 2019 •
edited

Follow up to #107

Builds upon existing FeedCommand, inspired by BingWebSearchCommand

Command word: googlenews
Command alias: gnews
gnews returns top stories
gnews [KEYWORD] [MORE_KEYWORDS]... returns news search

@rlrh rlrh added this to the v1.3 milestone Apr 2, 2019
@rlrh rlrh changed the title Add Google News search command [LOW-PRIORITY] Add Google News search command Apr 2, 2019
thomastanck
thomastanck previously requested changes Apr 2, 2019
View reviewed changes
Copy link

@thomastanck thomastanck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than minor style issue, LGTM.

src/main/java/seedu/address/logic/parser/EntryBookParser.java Outdated Show resolved Hide resolved
@coveralls
Copy link

coveralls commented Apr 2, 2019 •
edited

Pull Request Test Coverage Report for Build 617

  • 0 of 12 (0.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.4%) to 84.171%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/main/java/seedu/address/logic/parser/EntryBookParser.java 0 1 0.0%
src/main/java/seedu/address/logic/commands/GoogleNewsCommand.java 0 4 0.0%
src/main/java/seedu/address/logic/parser/GoogleNewsCommandParser.java 0 7 0.0%
Totals Coverage Status
Change from base Build 616: -0.4%
Covered Lines: 2010
Relevant Lines: 2388
💛 - Coveralls

qjqqyy
qjqqyy approved these changes Apr 2, 2019
View reviewed changes
Copy link

@qjqqyy qjqqyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks gtm

@qjqqyy qjqqyy dismissed thomastanck’s stale review April 2, 2019 15:01

changes resolved

@rlrh rlrh changed the title [LOW-PRIORITY] Add Google News search command Add Google News search command Apr 2, 2019
@rlrh rlrh merged commit 118860e into CS2103-AY1819S2-W10-1:master Apr 2, 2019
@rlrh rlrh deleted the google-news branch April 2, 2019 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qjqqyy qjqqyy qjqqyy approved these changes

@thomastanck thomastanck thomastanck left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.3
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rlrh @coveralls @thomastanck @qjqqyy