Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for refreshing entries #133

Merged
merged 3 commits into from
Apr 5, 2019

Conversation

thomastanck
Copy link

Resolves #56.

Summary of changes:

  • Rename RefreshCommand to RefreshFeedCommand to disambiguate with RefreshEntryCommand.
  • Implement RefreshEntryCommand

Part of epics:

@coveralls
Copy link

coveralls commented Apr 4, 2019

Pull Request Test Coverage Report for Build 682

  • 0 of 32 (0.0%) changed or added relevant lines in 7 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.9%) to 83.773%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/main/java/seedu/address/logic/parser/EntryBookFeedsParser.java 0 1 0.0%
src/main/java/seedu/address/logic/parser/EntryBookListParser.java 0 1 0.0%
src/main/java/seedu/address/logic/commands/RefreshFeedCommand.java 0 2 0.0%
src/main/java/seedu/address/logic/parser/RefreshEntryCommandParser.java 0 3 0.0%
src/main/java/seedu/address/model/ModelManager.java 0 4 0.0%
src/main/java/seedu/address/logic/parser/RefreshFeedCommandParser.java 0 6 0.0%
src/main/java/seedu/address/logic/commands/RefreshEntryCommand.java 0 15 0.0%
Totals Coverage Status
Change from base Build 681: -0.9%
Covered Lines: 2096
Relevant Lines: 2502

💛 - Coveralls

Copy link

@epicfailname epicfailname left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@epicfailname
Copy link

Possible extension in future could be that a refresh command, without any index given, refreshes the selected entry (and prompts for index if there is no selected entry)

@thomastanck thomastanck merged commit 81cd7e9 into CS2103-AY1819S2-W10-1:master Apr 5, 2019
@thomastanck thomastanck deleted the refresh-entry branch April 5, 2019 03:24
@thomastanck thomastanck added this to the v1.4 milestone Apr 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

As a heavy user, I can re-download content from previously saved links
3 participants