Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(Asynchronously) Download undownloaded articles on select #170

Merged
merged 13 commits into from
Apr 7, 2019
Merged

(Asynchronously) Download undownloaded articles on select #170

merged 13 commits into from
Apr 7, 2019

Conversation

thomastanck
Copy link

@thomastanck thomastanck commented Apr 6, 2019 •
edited

Resolves part of #169, #156.

Summary of changes:

  • Add async interface to Network
  • On selection, check if entry is un-downloaded, and download it if so.

@thomastanck thomastanck force-pushed the select-downloads-undownloaded branch from 9986ac3 to d0cd64d Compare April 6, 2019 17:58
@coveralls
Copy link

coveralls commented Apr 6, 2019 •
edited

Pull Request Test Coverage Report for Build 769

  • 27 of 28 (96.43%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 83.7%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/main/java/seedu/address/model/ModelManager.java 10 11 90.91%
Totals Coverage Status
Change from base Build 766: 0.2%
Covered Lines: 2090
Relevant Lines: 2497
💛 - Coveralls

@thomastanck thomastanck force-pushed the select-downloads-undownloaded branch from 371622b to 02fa6c5 Compare April 6, 2019 18:30
@thomastanck thomastanck force-pushed the select-downloads-undownloaded branch from 02fa6c5 to 1e71b85 Compare April 6, 2019 18:34
@thomastanck thomastanck mentioned this pull request Apr 6, 2019
Open
@thomastanck thomastanck closed this Apr 6, 2019
@thomastanck thomastanck deleted the select-downloads-undownloaded branch April 6, 2019 20:31
@thomastanck thomastanck restored the select-downloads-undownloaded branch April 6, 2019 20:31
@thomastanck thomastanck reopened this Apr 6, 2019
rlrh
rlrh reviewed Apr 7, 2019
View reviewed changes
Copy link

@rlrh rlrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mention in title and description that Network is also async now?

rlrh
rlrh requested changes Apr 7, 2019
View reviewed changes
Copy link

@rlrh rlrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can use the latest version of async-http-client.
Other than that, LGTM.

build.gradle Outdated Show resolved Hide resolved
src/main/java/seedu/address/util/Network.java Show resolved Hide resolved
@thomastanck thomastanck changed the title Download undownloaded articles on select (Asynchronously) Download undownloaded articles on select Apr 7, 2019
@thomastanck thomastanck requested a review from rlrh April 7, 2019 04:49
@thomastanck thomastanck merged commit 272d530 into CS2103-AY1819S2-W10-1:master Apr 7, 2019
@thomastanck thomastanck deleted the select-downloads-undownloaded branch April 7, 2019 05:11
@thomastanck thomastanck added this to the v1.4 milestone Apr 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@epicfailname epicfailname epicfailname left review comments

@rlrh rlrh rlrh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.4
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@thomastanck @coveralls @rlrh @epicfailname