Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Autofill contents when subscribing #173

Merged
merged 10 commits into from
Apr 10, 2019
Merged

Autofill contents when subscribing #173

merged 10 commits into from
Apr 10, 2019

Conversation

qjqqyy
Copy link

@qjqqyy qjqqyy commented Apr 6, 2019 •
edited

Changes

Autofills title and description when subscribing to feed.
Resolves #46

While here also slightly refactor Autofill API:

  • Autofill now is constructed with an Entry (instead of Title and Description)
  • Autofill finishes its job with a getFilledEntry() which returns Entry

@qjqqyy qjqqyy added this to the v1.4 milestone Apr 6, 2019
@qjqqyy qjqqyy requested a review from rlrh April 6, 2019 19:58
@coveralls
Copy link

coveralls commented Apr 6, 2019 •
edited

Pull Request Test Coverage Report for Build 779

  • 15 of 36 (41.67%) changed or added relevant lines in 5 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.6%) to 83.062%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/main/java/seedu/address/logic/commands/SubscribeCommand.java 0 9 0.0%
src/main/java/seedu/address/model/entry/util/EntryAutofill.java 8 20 40.0%
Files with Coverage Reduction New Missed Lines %
src/main/java/seedu/address/model/entry/util/EntryAutofill.java 1 73.21%
Totals Coverage Status
Change from base Build 770: -0.6%
Covered Lines: 2089
Relevant Lines: 2515
💛 - Coveralls

rlrh
rlrh previously requested changes Apr 7, 2019
View reviewed changes
Copy link

@rlrh rlrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice refactor of Autofill.
I think I originally did not take in and return an Entry because there used to be an offlineLink field.

src/main/java/seedu/address/model/entry/util/EntryAutofill.java Show resolved Hide resolved
src/main/java/seedu/address/model/entry/util/EntryAutofill.java Outdated Show resolved Hide resolved
src/main/java/seedu/address/logic/commands/SubscribeCommand.java Show resolved Hide resolved
@qjqqyy qjqqyy requested a review from rlrh April 7, 2019 07:27
epicfailname
epicfailname approved these changes Apr 9, 2019
View reviewed changes
Copy link

@epicfailname epicfailname left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qjqqyy qjqqyy dismissed rlrh’s stale review April 10, 2019 00:43

changes addressed

@qjqqyy qjqqyy merged commit 5ebf751 into master Apr 10, 2019
@qjqqyy qjqqyy deleted the autofill-feed branch April 10, 2019 00:43
@thomastanck thomastanck mentioned this pull request Apr 14, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@epicfailname epicfailname epicfailname approved these changes

@rlrh rlrh Awaiting requested review from rlrh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.4
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@qjqqyy @coveralls @rlrh @epicfailname